fix: Mistake inside ExcellentEconomy enum name (depreciate old usage) - #9
Merged
Conversation
feat: update gradle to 9.6.1, need to compile with jdk 25 (excellenteconomy was compile with jdk 25)
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 31 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's Gradle build system to use Gradle 9.6.1 and Java 25, and introduces improvements to the
Currenciesenum to support deprecated aliases for backward compatibility. Additionally, it refines the Gradle wrapper scripts for better error handling and compliance, and updates documentation to guide users on resolving currency names safely.Build system upgrades and compatibility:
gradle/wrapper/gradle-wrapper.properties,.github/workflows/build.yml) [1] [2]gradlew,gradlew.bat) with SPDX license identifiers, improved error messages, better environment handling, and switched to using the-jaroption for launching Gradle. (gradlew,gradlew.bat) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Currencies enum improvements:
EXCELLENTEECONOMYforEXCELLENTECONOMYin theCurrenciesenum, ensuring old configs and code remain compatible, and introduced thefromName(String)method to resolve names safely while logging warnings for deprecated usage. (src/main/java/fr/traqueur/currencies/Currencies.java) [1] [2] [3]Documentation updates:
fromName(String)method, and clarify the handling of deprecated aliases for backward compatibility. (readme.md) [1] [2]