Functest: Implement wait-power-down EngineSetupManagerAction - #1111
Merged
Conversation
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a new wait-power-down EngineSetupManager action to the Functest engine, and updates the dummy CI functest case to use that action instead of a raw host sleep step.
Changes:
- Added
WaitPowerDowntoModels::EngineSetupManagerActions. - Updated the dummy functest case to use
engine_setup_manager_action: "wait-power-down"for the power-down waiting step. - Implemented handling for
WaitPowerDowninFunctest#engine_setup_manager_callback(and expanded RuboCop metric disables for that method).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/models/command_info.rb | Adds the wait-power-down enum value for engine setup manager actions. |
| lib/engines/functest/tests/cases/dummy_ci/engine_setup_manager_action.json | Switches the “wait for power down” step from host_run: sleep 120 to the new engine action. |
| lib/engines/functest/functest.rb | Implements the new WaitPowerDown action branch in the engine callback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
elizashurov
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.