feat: improve Cargo.toml & introduce basic clippy - #941
Merged
Conversation
1. Removed useless patch version pinning 2. Updated workspace section 3. Added basic linting for the whole workspace 4. Added general lints (`all`) 5. Grouped and sorted dependencies for better readability Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
These are safe automatic fixes that clippy can immediately apply. Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Most of these are very mechanical, none have a bigger scope Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
georglauterbach
force-pushed
the
fix/cargo-toml
branch
from
August 16, 2026 22:44
4ef2aa1 to
8eb892e
Compare
Contributor
Author
|
I have not added CI checks for clippy & rustfmt. IMO they are really important, though, but I wanted to ask first. What do you think? EDIT: I have added the job and you can see it now running. The warnings by rustdoc should be resolved in a dedicated PR later. |
Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Owner
|
Thanks! I like the CI idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the patchset looks very big, I urge you to review commit-by-commit here. This really eases reviewing and makes sure you get a good picture of what actually changed.
Closes #940