FFI sendfile64 -> sendfile - #6
Open
PaulRivier wants to merge 1 commit into
Open
PaulRivier wants to merge 1 commit into
PaulRivier wants to merge 1 commit into
Conversation
sendfile64 does not exist on Alpine/MUSL, it exists as "sendfile" and is 64b by default This fix is necessary to build this package on Alpine/musl. Full compatibility with glibc 32b may require preprocessor conditionals that are not included in this minimal fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendfile64 does not exist on Alpine/MUSL,
it exists as "sendfile" and is 64b by default
This fix is necessary to build this package on Alpine/musl.
Applied to glibc, this fix would cap the max file size to ~2GB.
Therefore cross libc compatibility with large files support for glibc would require preprocessor conditionals to decide the FFI call (sendfile or sendfile64), that are not included in this minimal fix.
If maintainers are interested, I may write such preproc conditionnals and update the pull request.