Add review-coverage CI check (report mode) - #706
Draft
kriszyp wants to merge 3 commits into
Draft
Conversation
Informational check surfacing how many cross-model reviews the PR description names, using the dispatch human-review gate's own parser (HarperFast/dispatch/actions/review-coverage). Always green in report mode; under-reported substantive PRs get a warning annotation. See dispatch#59 for the action and skills/pr-shepherd/SKILL.md for policy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Org policy rejects mutable refs; renovate bumps pinned action shas, so the caller still tracks dispatch@main at dep-bot cadence. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
GitHub bars public repos from using private-repo actions, so the action lives in HarperFast/harper (.github/actions/review-coverage), pinned by sha per org policy; renovate bumps the pin. Currently pinned to the harper PR branch head — bump to a main sha once harper#2183 merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
Adds the review-coverage CI check in report mode — informational only, never blocks. On every PR open / description edit / push / ready-for-review, it parses the PR description and surfaces how many cross-model reviews it names, plus whether the
Human-Review-Need:footer is present and current vs the head sha. Under-reported substantive PRs (org-member author, >2 changed lines, non-draft) get a::warning::annotation; bots, outside contributors, trivial changes, and drafts are exempt.Uses the action hosted in harper (its public home — GitHub bars public repos from using private-repo actions; see harper#2183), pinned by full sha per org policy; renovate bumps the pin. Currently pinned to the harper PR branch head — bump to a main sha once harper#2183 merges (the check works either way; branch commits stay fetchable).
Context: the dispatch review fleet now gates substantive member PRs whose AI review finds issues and whose description reports fewer than two cross-model reviews (auto request-changes until coverage is reported). This check makes that expectation visible at PR open. Flipping to
mode: enforceis deliberately not part of this PR — that's a team policy call.Verification
This PR dogfoods the check: the run on this branch is green and correctly reports
exempt: draft. The action + evaluation script were reviewed and tested in dispatch#59 and carry 33 unit tests in harper#2183.Review coverage
— Claude Fable 5 (dispatched by Kris)
🤖 Generated with Claude Code