fix: follow dl.min.io redirects when downloading mc; move builds to monthly - #8
Merged
Conversation
…onthly The scheduled build has failed on every run since 2026-04-27 (18 consecutive failures, all "minisign: invalid signature"). dl.min.io no longer serves binaries directly - it now 302-redirects to GitHub Releases. The mc download used `curl -s -q` with no -L, so curl wrote the 149-byte HTML redirect stub to /usr/bin/mc and /usr/bin/mc.minisig and minisign correctly rejected it. The signing key never rotated: the key ID in the real signature (f1e59af5b621d02f) still matches the pubkey pinned in the Dockerfile, and both the file and global signatures verify against it once -L is used. - curl -s -q -> curl -fsSL. -L is the fix; -f makes any future HTTP error fail the build loudly instead of silently saving an error page over the binary. - Shallow-clone minio/minio. It is archived upstream (read-only, last code change 2025-10-24), so full history is never needed. Also move the schedule from weekly to monthly. Every build input is frozen: minio/minio is archived, the console and mds refs are pinned, and mc has not been republished since RELEASE.2025-08-13. The only thing a rebuild can pick up is an Alpine base-image security patch, so weekly rebuilds produced an identical image. Build 1.7.3 had no schedule at all and had not rebuilt since 2026-02-17; it now gets monthly patches too, staggered a day apart. Switch to a registry build cache rather than type=gha, since GitHub evicts unused caches after 7 days and would leave every monthly run cold. Docs corrected: CLAUDE.md described a workflow file that does not exist (docker-build-push.yml), a daily cron, and minio/object-browser as the UI source - that repo has been deleted upstream.
Cairn is a self-hosted, S3-compatible object store written in Rust with the console built into the binary. Framed against why this image exists in the first place, and flagged as active development / not production-ready.
PR build hit a transient proxy.golang.org failure 248s into the go build: go-oidc/v3@v3.14.1: read ".../v3.14.1.zip": stream error: INTERNAL_ERROR One dropped HTTP/2 stream should not kill a multi-arch build that takes an hour. Pre-fetch modules in a retry loop before building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 18 consecutive scheduled-build failures (2026-04-27 → 2026-08-24), every one
minisign: invalid signatureon the sameRUNstep.Root cause
dl.min.iono longer serves binaries directly — it 302-redirects to GitHub Releases. Themcdownload usedcurl -s -qwith no-L, so curl saved the 149-byte HTML redirect stub as both/usr/bin/mcand/usr/bin/mc.minisig, and minisign correctly rejected the garbage.The signing key never rotated. Verified before changing anything:
f1e59af5b621d02f) matches the pubkey pinned in the Dockerfile.-L, both the file signature and the global signature verify against that exact pubkey — onamd64andarm64.Timing corroborates:
minio/miniowas archived 2026-04-24, between the last green run (04-20) and the first red one (04-27).Changes
curl -s -q→curl -fsSL.-Lis the fix;-fmakes any future HTTP error fail the build loudly instead of silently saving an error page over the binary.minio/minio— archived upstream, so full history is never needed.minio/minioarchived (no code change since 2025-10-24), console +mdsrefs pinned,mcfrozen atRELEASE.2025-08-13. The only moving part isalpine:latest, so weekly rebuilds produced an identical image.Build 1.7.3had no schedule at all and had not rebuilt since 2026-02-17 — its base layer was rotting. Now monthly too, staggered a day apart.type=gha(GitHub evicts unused caches after 7 days, leaving every monthly run cold). Adds twobuildcache-*tags to Docker Hub.packages: write; addedconcurrencycancel-in-progress.docker-build-push.yml), a daily cron, andminio/object-browseras the UI source — that repo has been deleted upstream.Validation
This PR runs
Build Latestwithpush: false, which exercises the full multi-arch build including themcdownload and minisign verification — without publishing.Not addressed here (warnings, not failures): the five actions are each one major behind (Node 20 deprecation),
node:18-alpineis past EOL, and nativeubuntu-24.04-armrunners would cut build time more than caching does.