* correct TUX2/TUX3 native disk-format claims - #192
Open
Hawkynt wants to merge 1 commit into
Open
Conversation
- remove the private TUX2FS/TUX3WORM writers, mutators and record movers - treat TUX2 as non-self-identifying/opaque instead of inventing a standalone magic - parse the canonical linux-tux3 packed big-endian disksuper at byte 4096 - recognize current 2014-05-06 and known 2012-12-20 TUX3 disk revisions - replace self-roundtrip writer tests with native-layout and capability-honesty tests TUX3 upstream source is GPL; implementation is clean-room from factual on-disk field definitions and constants, with no expressive source translation.
Hawkynt
marked this pull request as ready for review
September 6, 2026 12:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The TUX2/TUX3 descriptors were advertising native R/W on formats that only round-tripped private Workbench layouts (
TUX2FSandTUX3WORM). This removes those interoperability claims instead of preserving synthetic writers behind native filesystem names.TUX2FSmagic or writer. The historical TUX2 design was an Ext2 variation intended to mount existing Ext2 partitions and never established a stable independent self-identifying disk format. Manual selection now surfaces the raw image plus metadata, with Ext2 magic reported only as a compatibility clue.struct disksuperat byte 4096, decodes all integer fields big-endian, and recognizes the current 2014-05-06 disk revision plus the known 2012-12-20 revision.TUX3SUPR/TUX3WORMdialect, its writer/modifier/block mover, and the equivalent TUX2 synthetic mutation stack are removed.Design / licensing
A valid TUX3 filesystem is more than a stamped superblock: upstream
mkfsalso creates allocation metadata, internal inodes, the atom table, root directory, and commit state. Emitting only a correct-looking header would be another synthetic format, soCanCreate/CanModifyremain withheld until those native structures are implemented and externally accepted.The canonical TUX3 implementation is GPL. No expressive upstream implementation code is copied or translated. This change is a clean-room implementation from factual/specification-defined field offsets, endian rules, revision magic bytes, and published behavior.
No new dependencies.
References
OGAWAHirofumi/linux-tux3,fs/tux3/tux3.h: current disk-format magic,SB_LOC, packedstruct disksuper, big-endian field types.mkfspath used as a behavioral/specification oracle for what constitutes a real filesystem.Validation
CI pending on this PR.