# Quake PAK was implemented as SEA ARC - #199
Open
Hawkynt wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format was not Quake PAK
FileFormat.Pakidentified itself as id Software's QuakePACKarchive, but its reader, writer and modifier all delegated to SEA ARC. The tests agreed with the implementation rather than the format: they explicitly asserted ARC's0x1A 0x00end marker. As a result, files produced by this descriptor were not Quake PAK files and realPACKarchives could not be read by it.The released Quake source defines the format directly:
"PACK", little-endian directory offset, little-endian directory lengthchar name[56],int filepos,int filelenWhat changed
PACKheader/directory readerFileFormat.Arcproject dependency entirelyPACKmagic to the descriptorChanged-byte editing
Canonical Quake PAK is also a much better random-access format than the old implementation implied. Its directory is already the trailer:
So for canonical archives the cost is O(directory metadata + changed payload bytes), not O(total archive bytes).
Tests
PACKvector pins the real 12-byte header and 64-byte directory record; it does not use our writerReference: id Software's released Quake
WinQuake/common.c/QW/client/common.cdefinitions ofdpackheader_t,dpackfile_t, andMAX_FILES_IN_PACK. No implementation code was copied; the repository implementation is written from the published structure definitions.