chore: bump dependency pins, fix README drift, add LICENSE and .env.example - #3
Draft
HelloBryte wants to merge 3 commits into
Draft
chore: bump dependency pins, fix README drift, add LICENSE and .env.example#3HelloBryte wants to merge 3 commits into
HelloBryte wants to merge 3 commits into
Conversation
…atest minor/patch - PySide6 6.10.3 -> 6.11.2 - mysql-connector-python 9.4.0 -> 9.7.0 (stayed on the 9.x line; skipped the 26.x jump, which is a major renumbering, not a conservative bump) - python-dotenv 1.1.1 -> 1.2.3 - httpx already at latest (0.28.1) Verified with a pip --dry-run install that the pinned set still resolves cleanly.
- Add MIT LICENSE file: README already claimed the MIT License but no LICENSE file existed in the repo. - Fix README (EN + ZH): face recognition is only used to enroll/update a face on the registration and profile screens, never for the login screen itself (login_window.py has no face-recognition code path). Previous wording claimed login also supported/disabled face recognition, which doesn't match the code. - Point the clone instructions at the actual repo URL instead of the https://github.com/your-username/ciims.git placeholder.
Add a proper .env.example listing every setting config.py reads (database, face recognition, AI assistant, app, logging, security), each commented out with its default. Replaces the ad-hoc env snippet that used to live inline in the README; the README now just points at `cp .env.example .env`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requirements.txtpins conservatively: PySide6 6.10.3 → 6.11.2, mysql-connector-python 9.4.0 → 9.7.0 (stayed on the 9.x line, avoided the major 26.x renumbering), python-dotenv 1.1.1 → 1.2.3LICENSEfile (MIT, as already claimed by the README).env.examplelisting every settingconfig.pyreads, and simplified the README's Configuration section tocp .env.example .envNote
Attempted to delete the stale, already-merged branch
claude/eager-hopper-vytuqabut the push credential in this environment returned 403 (no delete/write-ref permission). It's confirmed merged intomainand safe to delete manually.Verification
python -m py_compileover every.pyfile — all passpip install --dry-runagainst the newrequirements.txt— resolves cleanly, no conflictsGenerated by Claude Code