Fix SlackZipFileIF deserializing as SlackGdocFile - #471
Merged
VictorHLi404 merged 2 commits intoAug 25, 2026
Merged
Conversation
Contributor
|
@gilanisaeed Change looks good, but can you validate by adding a test inside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlackZipFileIF's @JsonDeserialize annotation pointed at SlackGdocFile.class instead of SlackZipFile.class (copy-paste slip when the zip filetype was added). As a result, JSON deserialized through the SlackZipFileIF interface produced SlackGdocFile instances, so instanceof SlackZipFile checks failed.
This changes the annotation to SlackZipFile.class, matching every other file type in the package. Verified this was the only remaining mismatch across the *IF.java files (the equivalent typo in SlackGdocFileIF was already fixed in ddccb6d).