Fix TypeError with yapf>=0.32 during config formatting - #283
Open
shihangan wants to merge 1 commit into
Open
Conversation
The 'verify' parameter was removed in yapf 0.32.0, causing training to crash immediately with: TypeError: FormatCode() got an unexpected keyword argument 'verify' This commit adds a try-except fallback to support both old (<0.32) and new (>=0.32) yapf versions. Tested on: - yapf 0.31.0 (old): verify=True works - yapf 0.40.2 (new): falls back to no verify parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Training crashes immediately when using yapf >= 0.32 with the following error:
TypeError: FormatCode() got an unexpected keyword argument 'verify'
This occurs in
util/slconfig.pyline 317, where the config object is formatted before saving tologs/.../config_cfg.py.Root Cause
yapf removed the
verifyparameter in version 0.32.0, but DINO still passesverify=True. Since most users now install yapf >= 0.32 by default (pip install yapf), this affects all new environments.Solution
This PR adds a try-except fallback:
verify=Trueworks as beforeTypeErrorand calls without the parameterNo behavior change — newer yapf versions perform verification internally by default.
Testing
Tested on:
verify=Trueaccepted, config file formatted correctlyChecklist