Fix the exam view (kiosk mode) fix from PR 11880 - #11918
Merged
Merged
Conversation
The commit with the fix for <https://mantis.ilias.de/view.php?id=48066> contains an issue: it misses a method call in the chain, thereby passing a string to a factory getter (which is ignored as it is not expected), and passing that factory on instead of a UI component that should be used. Properly obtain the Legacy factory. Then call the appropriate method on it which converts an HTML snippet (as string) to a UI component which can be included in the UI component for the title. See the API documentation for method “content” in ILIAS\UI\Component\Legacy\Factory for why this is chosen. Fixes-Mantis-Issue: https://mantis.ilias.de/view.php?id=48066 Fixes-Mantis-Issue: https://mantis.ilias.de/view.php?id=48174 Fixes-Pull-Request: ILIAS-eLearning#11880 Fixes-Commit: 76f84ae Fixes-Commit: d2b2b7e
Contributor
|
Hello @kergomard, Please take a look at this PR when you have a moment. This minor adjustment is required for both ILIAS 11 and ILIAS 12. For details on why it’s needed, please see this Mantis comment: https://mantis.ilias.de/view.php?id=48066#c126788 Best regards, |
Contributor
|
Yep, this is a cherry-picking issue and one more reminder why
Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that #11880, which has recently been merged to trunk and the release 11 branches, is unfortunately erroneous.
This pull request contains a suggested fix.
Please see the commit message for details.
We suggest to merge this to trunk and to cherry-pick it to
release_11. Otherwise people upgrading to ILIAS 11.3 (like us) will be unhappy when they try to start a test in kiosk mode that shows a participant’s name.