Declare project root with eigs.json (v0.43.0 resolution) - #108
Merged
Conversation
Seventeen `x is ...` sites inside functions wrote names that also exist at module scope (`result`, `t0`, `t1`, `ms`, `parsed`, `cfg`) or a builtin's name (`negative`). On the VM these are locals on the first call and outer writes once the module binding exists -- harmless here because the module reassigns them after every call -- but the AOT refuses the ambiguity by name (ouroboros#86 measured 2026-09-03: "function 'dpll_rec' assigns module name 'result' whose first module-level binding does not provably precede the function's first use", then the same for run_benchmarks' timing names, then "`negative is ...` writes the GLOBAL builtin binding"). `local` makes each of them what they were meant to be. VM output on tests/corpus/k4_3color_unsat.cnf and --bench is unchanged; `bash aot/build.sh minisat.eigs` now builds, and the native binary's output on the corpus instances matches the VM's modulo the ms field. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FDZZDgZDoJxPFBaPH5NkG3
benchmarks/*.eigs (dump_tseitin_cnf, tseitin_ladder) sit in a subdirectory and load root-relative lib/ paths (lib/dimacs.eigs etc.); under v0.43.0 (#1056, file-relative + project-root resolution, cwd step removed) those resolve only via a project-root marker. minisat.eigs at the root already worked (file-relative), which is why the smoke suite passed — the benchmark/emitter subdir files did not. eigs.json at the root fixes them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark/emitter subdir files (benchmarks/dump_tseitin_cnf.eigs etc.) load root-relative lib/ paths and break on v0.43.0 (#1056 file-relative + project-root resolution). minisat.eigs at the root already worked file-relative, so the smoke suite missed this. eigs.json at the root resolves the subdir loads. Surfaced while wiring native MiniSat as the fast UNSAT oracle for the AOT differential.