ci: delete the -m32 ILP32 approximation gate; the real wasm build is required (#1274) - #1283
Merged
Merged
Conversation
…required (#1274) tools/ilp32_syntax_check.sh (3,123 lines) and suite [99i3] compiled the playground's translation units with host clang -m32, an approximation of emcc's wasm32 target that #1255 showed can pass while the real build fails (i386 aligns double to 4, wasm32 to 8). Since #1267 the real `web/build.sh` under emcc runs on every PR, and since #1273 `playground (real emcc wasm32 build)` is a required check, so the approximation has nothing left to guard. Removed with it: the [99i3] runner section, its werror SCRIPT_AUDITS entry and floor row, and the doc prose describing its internals. CI.md and PERFORMANCE.md keep the #1255 history in the past tense and now name the real build as the check. CI.md's "until it is in the ruleset" sentence was stale since #1273 and now says the check is required. child_exit_check's floor drops 128 -> 126 for the two child invocations the section held. First step of the #1275 consolidation (net -3,468 lines). Closes #1274 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ite (#1274) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
) The gate was added and deleted within the same unreleased cycle, so its entries described something no release ships. Three gate-only bullets are removed; the #1255 and #1185 entries now name the real wasm32 build as the check. Found by a blind critic. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1274. First step of #1275 (gate consolidation).
What: deletes
tools/ilp32_syntax_check.sh(3,123 lines) and suite[99i3]. It compiled the playground's translation units with hostclang -m32, an approximation of emcc's wasm32 target that #1255 showed can pass while the real build fails (i386 alignsdoubleto 4, wasm32 to 8). Since #1267 the realweb/build.shunder emcc runs on every PR, and since #1273playground (real emcc wasm32 build)is a required check. The approximation guards nothing the required check doesn't.Removed with it:
[99i3]runner sectionSCRIPT_AUDITSentry and floor row, plus the ~30-line floor history commentdocs/PERFORMANCE.md,docs/CI.md)Floors lowered deliberately (each gate asks for this in the same commit when coverage is removed):
child_exit_checkCHILD_SITES_FLOOR128 → 126 (the section's two child invocations)section_planSKIP_ROUTED_FLOOR26 → 25 (the section'ssection_skipsite)Doc fix alongside: CI.md said the wasm check was not yet in the ruleset. That was stale since #1273; it now says the check is required.
Net: +33 / −3,501 lines.
Local verification (4GB dev box):
make precheck: green after the floor changewerror_switch_check.sh+--selftest: greensection_plan.sh --selftest: 50 checks, 0 failuresdocs_claims_check.sh: greenissue_labels_checkon nightly lane: macos-15-intel / valgrind-full failures #1168, whose labels were missing. Unrelated GitHub state, the precheck: parallelise core_ext_boundary_check (the precheck's critical path, 17–35 s) #1279 class; nightly lane: macos-15-intel / valgrind-full failures #1168 is now labeled, and moving that check out of the suite is part of tooling: gate scripts grew 59x in 7 weeks (592 → 34,804 lines; half the runtime) — freeze, consolidate, budget #1275.🤖 Generated with Claude Code