Skip to content

ci: delete the -m32 ILP32 approximation gate; the real wasm build is required (#1274) - #1283

Merged
InauguralPhysicist merged 3 commits into
mainfrom
ci/retire-ilp32-gate-1274
Sep 23, 2026
Merged

InauguralPhysicist merged 3 commits into
mainfrom
ci/retire-ilp32-gate-1274

Conversation

@InauguralPhysicist

Copy link
Copy Markdown
Collaborator

Closes #1274. First step of #1275 (gate consolidation).

What: deletes tools/ilp32_syntax_check.sh (3,123 lines) and suite [99i3]. It compiled the playground's translation units with host clang -m32, an approximation of emcc's wasm32 target that #1255 showed can pass while the real build fails (i386 aligns double to 4, wasm32 to 8). Since #1267 the real web/build.sh under emcc runs on every PR, and since #1273 playground (real emcc wasm32 build) is a required check. The approximation guards nothing the required check doesn't.

Removed with it:

  • the [99i3] runner section
  • its werror SCRIPT_AUDITS entry and floor row, plus the ~30-line floor history comment
  • the doc prose describing its internals (docs/PERFORMANCE.md, docs/CI.md)

Floors lowered deliberately (each gate asks for this in the same commit when coverage is removed):

  • child_exit_check CHILD_SITES_FLOOR 128 → 126 (the section's two child invocations)
  • section_plan SKIP_ROUTED_FLOOR 26 → 25 (the section's section_skip site)

Doc fix alongside: CI.md said the wasm check was not yet in the ruleset. That was stale since #1273; it now says the check is required.

Net: +33 / −3,501 lines.

Local verification (4GB dev box):

🤖 Generated with Claude Code

InauguralPhysicist and others added 2 commits September 23, 2026 12:38
…required (#1274)

tools/ilp32_syntax_check.sh (3,123 lines) and suite [99i3] compiled the
playground's translation units with host clang -m32, an approximation of
emcc's wasm32 target that #1255 showed can pass while the real build fails
(i386 aligns double to 4, wasm32 to 8). Since #1267 the real `web/build.sh`
under emcc runs on every PR, and since #1273 `playground (real emcc wasm32
build)` is a required check, so the approximation has nothing left to guard.

Removed with it: the [99i3] runner section, its werror SCRIPT_AUDITS entry and
floor row, and the doc prose describing its internals. CI.md and
PERFORMANCE.md keep the #1255 history in the past tense and now name the real
build as the check. CI.md's "until it is in the ruleset" sentence was stale
since #1273 and now says the check is required. child_exit_check's floor
drops 128 -> 126 for the two child invocations the section held.

First step of the #1275 consolidation (net -3,468 lines).

Closes #1274

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ite (#1274)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@InauguralPhysicist InauguralPhysicist added area:ci Subsystem: ci area:gates Subsystem: gates labels Sep 23, 2026
@codspeed

codspeed Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing ci/retire-ilp32-gate-1274 (d2d5ffd) with main (3130a17)

Open in CodSpeed

)

The gate was added and deleted within the same unreleased cycle, so its
entries described something no release ships. Three gate-only bullets are
removed; the #1255 and #1185 entries now name the real wasm32 build as the
check. Found by a blind critic.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@InauguralPhysicist
InauguralPhysicist added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit f13d80c Sep 23, 2026
34 checks passed
@InauguralPhysicist
InauguralPhysicist deleted the ci/retire-ilp32-gate-1274 branch September 23, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Subsystem: ci area:gates Subsystem: gates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: retire or shrink the -m32 ILP32 approximation gate now that the real wasm build is required on every PR

1 participant