fix: panics, grayscale bug, duplicate filter, and process::exit in library code - #320
Open
Cybersnake223 wants to merge 2 commits into
Open
fix: panics, grayscale bug, duplicate filter, and process::exit in library code#320Cybersnake223 wants to merge 2 commits into
Cybersnake223 wants to merge 2 commits into
Conversation
…brary code - Replace todo!() panics in FilterReturnType conversion with empty string coercion - Fix grayscale filter calling invert() instead of grayscale_simple() on HSL - Remove duplicate set_blue filter registration in main.rs - Replace std::process::exit(1) with proper error propagation in format_hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
todo!()panics inFilterReturnTypeconversion —Value::Nullnow coerces to an empty string instead of panicking at runtimeinvert()instead ofgrayscale_simple()set_bluefilter registration — registered twice inmain.rs, second overwrote firststd::process::exit(1)with proper error propagation —format_hooknow returnsErrinstead of bypassing DropTesting
All 6 existing tests pass. No new warnings introduced.