feat: update VTL editor, align legacy on React 19, add standalone mode - #1238
Open
NicoLaval wants to merge 16 commits into
Open
feat: update VTL editor, align legacy on React 19, add standalone mode#1238NicoLaval wants to merge 16 commits into
NicoLaval wants to merge 16 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
NicoLaval
force-pushed
the
feat/update-vtl-editor
branch
from
August 23, 2026 20:01
8fae188 to
1f5029c
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
NicoLaval
force-pushed
the
feat/update-vtl-editor
branch
from
August 23, 2026 20:07
1f5029c to
6f8a9ae
Compare
NicoLaval
changed the title
Contributor
|
ça a l'air en good en première lecture ! Cependant, quelques fonctionnalité ne fonctionnent plus:
|
React 19 removes support for defaultProps on function components. Migrates all ~60 affected components to use default parameter values directly in destructuring, fixing crashes on "Voir le detail", the new question form, and the toolbar disappearing in next+legacy mode. Co-authored-by: Cursor <cursoragent@cursor.com>
redux-form injects `form` via defaultProps on a forwardRef HOC, which React 19 ignores. Wrap reduxForm so the form name is always provided. Co-authored-by: Cursor <cursoragent@cursor.com>
connect() containers no longer apply defaultProps under React 19. Default form name and componentId where the edit form still relied on them. Co-authored-by: Cursor <cursoragent@cursor.com>
Pass formName/selectorPath from the question form and default them in the container/component so the tab no longer mounts with undefined paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Parents often omit these props; container defaultProps no longer apply under React 19, so FormSection/formValueSelector would get undefined. Co-authored-by: Cursor <cursoragent@cursor.com>
AssociatedFields, SelectorView, OptionalView, GotoInput and ListWithInputPanel relied on connect defaultProps that React 19 drops. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid crashes when item label, date format or markdown content is missing after optional props stop being filled by defaultProps. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@laurentC35, thanks for the review. Root cause: under React 19, Fixes:
Keep me informed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev:standalone/pnpm standalone, docs updated)@making-sense/antlr-editorto 2.9.4 to fix VTL script validation errors in the UI (empty / partial expressions)