Continue prov-v2 implementation - #545
Merged
Merged
Conversation
hadrienk
reviewed
Aug 26, 2026
| * operands); single {@code calc} / {@code filter} / {@code sub} / {@code keep}|{@code drop} / | ||
| * {@code rename} on a dataset varId. Nested clauses and other ops stay unsupported. | ||
| */ | ||
| class SupportCheckVisitor extends VtlBaseVisitor<Void> { |
Collaborator
There was a problem hiding this comment.
Is there a way to make VtlBaseVisitor fail without having to overrides the methods? Alternatively, doesn't the unimplemented VtlBaseVisitor fails on it's own? Or can we not implement defaultResult() and throw the unsupported exception there?
Collaborator
Author
There was a problem hiding this comment.
SupportCheckVisitor is a kind of preflight, a bit annoying, but overriding defaultResult seems to be worth, because of other usage in the Parse tree walker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.