Move and deprecate dpctl program#2317
Conversation
also removes "v" as a permitted specialization constant intermediate data type, as composite specialization constants are broken into multiple specialization constants, so structs end up passed as a single constant while the program expects multiple, and therefore, doesn't work as intended
also adds spec_id, itemsize, and default_value fields
also removes attempted header installation from program submodule in setup.py
no longer contains sources
ndgrigorian
force-pushed
the
feature/specialization-constants
branch
from
97871d9 to
e2e4826
Compare
ndgrigorian
force-pushed
the
move-and-deprecate-dpctl-program
branch
from
e2c22db to
c82fa86
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2317/index.html |
|
Coverage is 75.023% — move-and-deprecate-dpctl-program into feature/specialization-constants. No base build found for |
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
| create_program_from_source, | ||
| create_program_from_spirv, |
There was a problem hiding this comment.
These functions have been removed according to https://github.com/IntelPython/dpctl/pull/2317/changes#diff-a37c9a5fefbe1e0d6b42a2039127ab8e44233f8b67976d271e47cea5ce6fedbdL557
| create_program_from_source, | ||
| create_program_from_spirv, |
There was a problem hiding this comment.
These functions have been removed according to https://github.com/IntelPython/dpctl/pull/2317/changes#diff-a37c9a5fefbe1e0d6b42a2039127ab8e44233f8b67976d271e47cea5ce6fedbdL557
| # cython: language_level=3 | ||
|
|
||
|
|
||
| """The Cython declarations for the functions defined in _program.pyx. |
There was a problem hiding this comment.
| """The Cython declarations for the functions defined in _compiler.pyx. |
| or a SPIR-V binary file. | ||
|
|
||
| It implements creation of interoperability | ||
| ``sycl::kernel_bundle<sycl::bundle_state_executable>`` (a collection of kernels), |
There was a problem hiding this comment.
Should be
| ``sycl::kernel_bundle<sycl::bundle_state_executable>`` (a collection of kernels), | |
| ``sycl::kernel_bundle<sycl::bundle_state::executable>`` (a collection of kernels), |
https://github.khronos.org/SYCL_Reference/iface/kernel-bundles.html#sycl-bundle-state-executable
There was a problem hiding this comment.
yep, good catch, typo
ndgrigorian
force-pushed
the
feature/specialization-constants
branch
from
53be0e1 to
d9f386b
Compare
ndgrigorian
force-pushed
the
feature/specialization-constants
branch
from
baa91b5 to
bbb322a
Compare
3 participants
This PR refactors dpctl.program into dpctl.compiler, removing the program submodule
This follows up on previous work to move away from long-deprecated names like
program, terminology no longer supported by the SYCL spec.