Fix initialization on headerless Steam CEF pages - #2377
Open
Acetab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Steam's built-in browser can render store app pages without the legacy
#global_headerelement. On these pages the content script may run before the client page has finished rendering, so the legacy page check fails and Augmented Steam does not initialize. Header-only widgets also assume that#global_action_menuand the legacy header are present.Changes
.responsive_page_frame.no_headeras a valid legacy page containerThe existing behavior on regular Steam web pages is unchanged: when the legacy header is available, the normal menu and warnings are mounted as before.
Testing
npx tsc --noEmitnpm run build chrome -- --productionRelated to #2307