Interface detect upload - #219
Merged
Merged
Conversation
…enchmark metadata (Windows/Linux/macOS), wiring the detected interface into BenchmarkDriveInfo via BenchmarkRunner.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds storage-interface (bus/transport) detection to the benchmark environment metadata so it can be persisted/serialized and submitted to the backend alongside existing drive information.
Changes:
- Adds OS-specific drive interface detection for macOS (
diskutil), Windows (PowerShellGet-Partition | Get-Disk), and Linux (lsblk TRAN). - Extends the benchmark data model (
BenchmarkDriveInfo) and environment mapping to includedriveInterface. - Enhances the About dialog to display the System ID with select/copy affordances.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| jdm-core/src/main/java/org/metricus/jdm/os/UtilsMacOs.java | Adds macOS interface detection via diskutil info parsing. |
| jdm-core/src/main/java/jdiskmark/UtilOs.java | Adds Windows/Linux helpers for interface detection. |
| jdm-core/src/main/java/jdiskmark/Util.java | Adds cross-platform getDriveInterface(File) resolution for the benchmark path. |
| jdm-core/src/main/java/jdiskmark/Gui.java | Updates About dialog to show/copy/select System ID. |
| jdm-core/src/main/java/jdiskmark/BenchmarkRunner.java | Captures and maps drive interface into the benchmark environment. |
| jdm-core/src/main/java/jdiskmark/BenchmarkDriveInfo.java | Adds driveInterface field for persistence/serialization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add interface detection to data model so it gets submitted to backend as part of benchmark