Skip to content

Add GetClosedOrdersAsync for Unified (UTA) trading API #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yaroslavnikolenko-design wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GetClosedOrdersAsync for Unified (UTA) trading API #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bitget.Net.UnitTests/Bitget.Net.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<ItemGroup>
<packagereference Include="Microsoft.NET.Test.Sdk" Version="18.0.1"></packagereference>
<PackageReference Include="Moq" Version="4.20.72" />
<packagereference Include="NUnit" Version="4.4.0"></packagereference>
Expand Down
54 changes: 54 additions & 0 deletions Bitget.Net.UnitTests/Endpoints/Unified/Trading/GetClosedOrders.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
GET
/api/v3/trade/history-orders
true
UriParams: {"category": "SPOT"}
{
"code": "00000",
"msg": "success",
"requestTime": 1730186730084,
"data": {
"list": [
{
"orderId": "111111111111111111",
"clientOid": "111111111111111111",
"category": "USDT-FUTURES",
"symbol": "BTCUSDT",
"orderType": "limit",
"side": "sell",
"price": "49534.4",
"qty": "0.429",
"amount": "0",
"cumExecQty": "0.429",
"cumExecValue": "21250.2929",
"avgPrice": "49534.4",
"timeInForce": "gtc",
"orderStatus": "filled",
"posSide": "long",
"holdMode": "hedge_mode",
"delegateType": "normal",
"reduceOnly": "NO",
"marginMode": "crossed",
"stpMode": "none",
"takeProfit": "",
"stopLoss": "",
"tpTriggerBy": "",
"slTriggerBy": "",
"tpOrderType": "",
"slOrderType": "",
"tpLimitPrice": "",
"slLimitPrice": "",
"feeDetail": [
{
"feeCoin": "USDT",
"fee": "4.2500586"
}
],
"cancelReason": "normal_cancel",
"execType": "liquidation",
"createdTime": "1730181468493",
"updatedTime": "1730181468493"
}
],
"cursor": "1233319323918499840"
}
}
1 change: 1 addition & 0 deletions Bitget.Net.UnitTests/RestRequestTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ public async Task ValidateUnifiedTradingCalls()
await tester.ValidateAsync(client => client.UnifiedApi.Trading.ClosePositionsAsync(ProductCategory.UsdtFutures), "ClosePositions", nestedJsonProperty: "data.list");
await tester.ValidateAsync(client => client.UnifiedApi.Trading.GetOrderAsync(), "GetOrder", nestedJsonProperty: "data", ignoreProperties: ["reduceOnly"]);
await tester.ValidateAsync(client => client.UnifiedApi.Trading.GetOpenOrdersAsync(), "GetOpenOrders", nestedJsonProperty: "data", ignoreProperties: ["reduceOnly"]);
await tester.ValidateAsync(client => client.UnifiedApi.Trading.GetClosedOrdersAsync(ProductCategory.Spot), "GetClosedOrders", nestedJsonProperty: "data");
await tester.ValidateAsync(client => client.UnifiedApi.Trading.GetUserTradesAsync(), "GetUserTrades", nestedJsonProperty: "data", ignoreProperties: ["isRPI"]);
await tester.ValidateAsync(client => client.UnifiedApi.Trading.GetPositionsAsync(ProductCategory.UsdtFutures), "GetPositions", nestedJsonProperty: "data.list");
await tester.ValidateAsync(client => client.UnifiedApi.Trading.GetPositionHistoryAsync(ProductCategory.UsdtFutures), "GetPositionHistory", nestedJsonProperty: "data");
Expand Down
26 changes: 26 additions & 0 deletions Bitget.Net/Clients/UnifiedApi/BitgetRestClientUnifiedApiTrading.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,32 @@ public async Task<HttpResult<BitgetUaOrders>> GetOpenOrdersAsync(

#endregion

#region Get Closed Orders (history)

/// <inheritdoc />
public async Task<HttpResult<BitgetUaOrders>> GetClosedOrdersAsync(
ProductCategory category,
string? orderId = null,
DateTime? startTime = null,
DateTime? endTime = null,
int? limit = null,
string? cursor = null,
CancellationToken ct = default)
{
var parameters = new Parameters(BitgetExchange._parameterSerializationSettings);
parameters.Add("category", category);
parameters.Add("orderId", orderId);
parameters.Add("startTime", startTime);
parameters.Add("endTime", endTime);
parameters.Add("limit", limit);
parameters.Add("cursor", cursor);
var request = _definitions.GetOrCreate(HttpMethod.Get, _baseClient.BaseAddress, "/api/v3/trade/history-orders", BitgetExchange.RateLimiter.Overall, 1, true, limitGuard: new SingleLimitGuard(20, TimeSpan.FromSeconds(1), RateLimitWindowType.Sliding));
var result = await _baseClient.SendAsync<BitgetUaOrders>(request, parameters, ct).ConfigureAwait(false);
return result;
}

#endregion

#region Get User Trades

/// <inheritdoc />
Expand Down
25 changes: 25 additions & 0 deletions Bitget.Net/Interfaces/Clients/UnifiedApi/IBitgetRestClientUnifiedApiTrading.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,31 @@ Task<HttpResult<BitgetUaOrders>> GetOpenOrdersAsync(
string? cursor = null,
CancellationToken ct = default);

/// <summary>
/// Get order history
/// <para>
/// Docs:<br />
/// <a href="https://www.bitget.com/api-doc/uta/trade/Get-Order-History" /><br />
/// Endpoint:<br />
/// GET /api/v3/trade/history-orders<br />
/// </para>
/// </summary>
/// <param name="category">["<c>category</c>"] Category</param>
/// <param name="symbol">["<c>symbol</c>"] Filter by symbol, for example `ETHUSDT`</param>
/// <param name="startTime">["<c>startTime</c>"] Filter by start time</param>
/// <param name="endTime">["<c>endTime</c>"] Filter by end time</param>
/// <param name="limit">["<c>limit</c>"] Max number of results, max 100</param>
/// <param name="cursor">["<c>cursor</c>"] Pagination cursor</param>
/// <param name="ct">Cancellation token</param>
Task<HttpResult<BitgetUaOrders>> GetClosedOrdersAsync(
ProductCategory category,
string? symbol = null,
DateTime? startTime = null,
DateTime? endTime = null,
int? limit = null,
string? cursor = null,
CancellationToken ct = default);

/// <summary>
/// Get user trades
/// <para>
Expand Down
Loading