Audit data types to ensure they agree with documentation/actual returned data. - #38
Merged
Merged
Conversation
seansfkelley
commented
Aug 24, 2026
seansfkelley
marked this pull request as ready for review
August 25, 2026 00:06
JacobHearst
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SLZ drop today revealed that the non-nullable fields on
Card.Previeware wrong; specifically they don't have asourceUribut the documentation says they are all nullable.I took the opportunity to go through and update all fields; besides the above it was just missing fields/enum values, rather than incorrect types/nullity, excepting the typoed
cardMarketId, which should becardmarketId(auto-camel-cased fromcardmarket_id).Edit: two days later it looks like Scryfall updated the SLZ cards to have a
sourceUri, so the inciting issue doesn't reproduce anymore, but this PR is still relevant because the fields are still documented as nullable.