Restore the lakes on a dynamic-mesh regeneration - #59
Open
JanStreffing wants to merge 1 commit into
Open
Conversation
The lake restore added in 437fdeb is off by default, which is right for a static regeneration: it changes published files, so it has to be asked for. The dynamic path is the opposite case. There the coastline moves with the ice sheet and the mask is rebuilt every cycle, so the flip destroys the lake fields again on every leg and nobody is there to ask. Measured on the TCO95 cavity submesh, both the pool chunk-1 ICMGG and the file couple_in regenerated for ismtest36 carry cl >= 0.5 at zero cells against 70 in the pristine input. The Caspian and the Great Lakes are among them, so FLake had nothing to integrate anywhere, on every -is run so far. Set through setdefault, so a template that has already decided still wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lake restore from #58 is off by default, which is right for a static regeneration: it changes published files, so it has to be asked for. The dynamic path is the opposite case. There the coastline moves with the ice sheet and the mask is rebuilt every cycle, so the flip destroys the lake fields again on every leg and nobody is there to ask.
Measured on the TCO95 cavity submesh, both the pool chunk-1 ICMGG and the file
couple_inregenerated for ismtest36 carrycl >= 0.5at zero cells, against 70 in the pristine input. The Caspian and the Great Lakes are among them, so FLake had nothing to integrate anywhere, on every-isrun so far.Set through
setdefault, so a template that has already decided still wins.