This repository was archived by the owner on Mar 29, 2026. It is now read-only.
feat, fix: Improved logging, improved handling of sockets, fixed crashing issues on Linux/Unix. - #24
Merged
Merged
Conversation
…d disconnect logic from heartbeat
…platforms, improved disconnection logic
Owner
Author
|
While this might pass unit tests, this needs a day to soaktest. A public RCON server usually gets a lot of invalid requests from people just sniffing ports and that's where I spotted the crash. Will leave this running for a while and see what happens. |
Owner
Author
|
Nice I made a system that just ends up waiting for a lock on first client and gets stuck, lovely stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a major issue on Linux/Unix with crashing during runtime, along with an improvement on logging (being a bit more clear with logs, error codes no longer being randomly thrown with no clue as to what it was relevant to) and an improvement with how sockets were handled to avoid ifdef spam.