feat: cleanup swim wrapper#1033
Draft
baltzell wants to merge 27 commits into
Draft
Conversation
baltzell
marked this pull request as ready for review
December 23, 2025 22:59
baltzell
requested review from
heddle,
tongtongcao and
zieglerv
as code owners
December 23, 2025 22:59
baltzell
force-pushed
the
swim-baltzell
branch
from
January 5, 2026 16:13
81580ff to
b6bf5dd
Compare
baltzell
force-pushed
the
swim-baltzell
branch
2 times, most recently
from
January 6, 2026 00:33
9e8f239 to
aef9bc2
Compare
baltzell
enabled auto-merge (squash)
January 6, 2026 01:48
baltzell
force-pushed
the
swim-baltzell
branch
from
January 6, 2026 14:52
aef9bc2 to
f6731b8
Compare
baltzell
force-pushed
the
swim-baltzell
branch
3 times, most recently
from
January 7, 2026 04:20
28d28ff to
f6f7ff1
Compare
baltzell
force-pushed
the
swim-baltzell
branch
from
January 14, 2026 15:44
f6f7ff1 to
b2ff1a9
Compare
baltzell
force-pushed
the
swim-baltzell
branch
from
January 16, 2026 23:19
b2ff1a9 to
2e1407b
Compare
baltzell
marked this pull request as draft
February 7, 2026 02:21
auto-merge was automatically disabled
February 7, 2026 02:21
Pull request was converted to draft
baltzell
force-pushed
the
swim-baltzell
branch
from
February 13, 2026 22:24
42136f8 to
5dce959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for new swimming versions, do a little reorganization of
org.jlab.clas.swimtools:ISwiminterface of appropriate methods fromSwimASwimfor shared data and generic wrapping of some simple geometry callsSwim, now extendsASwimStoppersSwimParsAdaptiveSwimAdaptiveSwimwith specific methods fromSwimTODO: remove stuff from
ISwim, add wrappers toASwim.Note,
Swim's interface and functionality is unchanged.