Skip to content

remove debug printouts and timing stuff#1349

Draft
baltzell wants to merge 13 commits into
rich-baltzellfrom
rich-baltzell-3
Draft

remove debug printouts and timing stuff#1349
baltzell wants to merge 13 commits into
rich-baltzellfrom
rich-baltzell-3

Conversation

@baltzell

@baltzell baltzell commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

depends on #1348

@baltzell baltzell changed the title remove debug and timing stuff remove debug printouts and timing stuff Jul 14, 2026
@c-dilks

c-dilks commented Jul 17, 2026

Copy link
Copy Markdown
Member

@raffaelladevita and @baltzell, here is the HEP data model for PID:

https://github.com/key4hep/EDM4hep/blob/8aa0fcd2176bc1981bd73b7558bc94d0cbcf6453/edm4hep.yaml#L380-L391

In the EIC use case, we have a 1-to-many relation from a reconstructed particle object to edm4hep::ParticleID objects, and a 1-to-1 relation to the "best" one; the "best" edm4hep::ParticleID object's PDG was assumed to be that reconstructed particle's PDG for anything that needs it downstream, e.g., kinematics calculations ($x$, $Q^2$, etc.).

For our case at CLAS12, I think the pindex column gives our "1-to-many" mapping of REC::Particle to REC::Hypothesis objects (see below), but I think we also need at least:

  • a status-like variable, not REC::Particle.status, would be useful for each hypothesis, indicating what was involved in that PID hypothesis; it would encode which detector(s), which algorithm(s), etc.
  • Some way of representing which REC::Hypothesis was assumed for setting the pid column of the REC::Particle

This is in reference to the schema proposed in this PR, copied here:

{
        "name": "REC::Hypothesis",
        "group": 300,
        "item": 50,
        "info": "Particle identification bank",
        "entries": [
            {"name":"pindex","type":"S", "info":"row index in REC::Particle"},
            {"name":"pid",   "type":"I", "info":"particle id hypothesis in LUND conventions"},
            {"name":"logl",  "type":"F", "info":"log(Likelihood) for this hypothesis"}
        ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants