CT-3223 | Standardise selectors in prep for Maestro - #338
Quality Gate failed
Failed conditions
17 Security Hotspots
11.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Annotations
Check warning on line 49 in Source/View/SectionView/JPSectionView.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPSectionView".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jI9y8hqXC4KraOp&open=AZ2b8jI9y8hqXC4KraOp&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPPaymentMethodsEmptyCardListCell".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jM6y8hqXC4KraPn&open=AZ2b8jM6y8hqXC4KraPn&pullRequest=338
Check warning on line 77 in Source/Modules/PaymentMethods/View/Subviews/JPPaymentMethodsHeaderView.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPPaymentMethodsHeaderView".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jLUy8hqXC4KraPW&open=AZ2b8jLUy8hqXC4KraPW&pullRequest=338
Check warning on line 56 in Source/Modules/CardScanController/JPCardScanController.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPCardScanController".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jJ4y8hqXC4KraO6&open=AZ2b8jJ4y8hqXC4KraO6&pullRequest=338
Check warning on line 75 in Source/Modules/PaymentMethods/View/Subviews/JPPaymentMethodsHeaderView.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPPaymentMethodsHeaderView".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jLUy8hqXC4KraPU&open=AZ2b8jLUy8hqXC4KraPU&pullRequest=338
Check warning on line 40 in Source/View/CardInputView/Subviews/ActionBar/JPActionBar.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPActionBar".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jGYy8hqXC4KraOW&open=AZ2b8jGYy8hqXC4KraOW&pullRequest=338
Check failure on line 134 in Source/Modules/Transaction/Presenter/JPTransactionPresenter.m
sonarqubecloud / SonarCloud Code Analysis
format string is not a string literal
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jPzy8hqXC4KraQN&open=AZ2b8jPzy8hqXC4KraQN&pullRequest=338
Check warning on line 13 in Examples/SPMExampleApp/SPMExampleApp/AppDelegate.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "options" or name it "_".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jYFy8hqXC4KraRT&open=AZ2b8jYFy8hqXC4KraRT&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPPaymentMethodsCardCell".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jMcy8hqXC4KraPk&open=AZ2b8jMcy8hqXC4KraPk&pullRequest=338
Check warning on line 651 in Source/Modules/Transaction/Presenter/JPTransactionPresenter.m
sonarqubecloud / SonarCloud Code Analysis
Remove the commented out code.
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jPzy8hqXC4KraQS&open=AZ2b8jPzy8hqXC4KraQS&pullRequest=338
Check warning on line 146 in fastlane/helpers.rb
sonarqubecloud / SonarCloud Code Analysis
Use a specific exception class instead of raising a string literal.
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8ja1y8hqXC4KraRr&open=AZ2b8ja1y8hqXC4KraRr&pullRequest=338
Check warning on line 263 in Source/Modules/PaymentMethods/View/JPPaymentMethodsViewController.m
sonarqubecloud / SonarCloud Code Analysis
Nullable pointer is passed to a callee that requires a non-null 1st parameter
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jPby8hqXC4KraQK&open=AZ2b8jPby8hqXC4KraQK&pullRequest=338
Check warning on line 6 in Examples/SPMExampleApp/SPMExampleApp/SceneDelegate.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "connectionOptions" or name it "_".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jXzy8hqXC4KraRP&open=AZ2b8jXzy8hqXC4KraRP&pullRequest=338
Check failure on line 142 in Source/View/CardInputView/Subviews/JPBillingInformationForm.m
sonarqubecloud / SonarCloud Code Analysis
format string is not a string literal
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jFQy8hqXC4KraOG&open=AZ2b8jFQy8hqXC4KraOG&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPPaymentMethodsEmptyHeaderView".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jOpy8hqXC4KraQB&open=AZ2b8jOpy8hqXC4KraQB&pullRequest=338
Check warning on line 635 in Source/Modules/Transaction/Presenter/JPTransactionPresenter.m
sonarqubecloud / SonarCloud Code Analysis
Nullable pointer is passed to a callee that requires a non-null 1st parameter
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jPzy8hqXC4KraQR&open=AZ2b8jPzy8hqXC4KraQR&pullRequest=338
Check warning on line 151 in Source/Modules/CardScanController/JPCardScanController.m
sonarqubecloud / SonarCloud Code Analysis
implicit conversion loses floating-point precision: 'CGFloat' (aka 'double') to 'VNAspectRatio' (aka 'float')
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jJ4y8hqXC4KraO2&open=AZ2b8jJ4y8hqXC4KraO2&pullRequest=338
Check warning on line 164 in Source/Models/Theme/JPTheme.m
sonarqubecloud / SonarCloud Code Analysis
implicit conversion turns floating-point number into integer: 'CGFloat' (aka 'double') to '_Bool'
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jD-y8hqXC4KraN-&open=AZ2b8jD-y8hqXC4KraN-&pullRequest=338
Check warning on line 65 in Source/View/CardInputView/Subviews/JPBillingInformationForm.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPBillingInformationForm".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jFQy8hqXC4KraOK&open=AZ2b8jFQy8hqXC4KraOK&pullRequest=338
Check warning on line 42 in Source/Modules/CardScanController/View/JPCardScanPreviewLayer.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPCardScanPreviewLayer".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jK2y8hqXC4KraPK&open=AZ2b8jK2y8hqXC4KraPK&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Identical sub-expressions on both sides of operator "="
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jVKy8hqXC4KraQ5&open=AZ2b8jVKy8hqXC4KraQ5&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPOtherPaymentMethodView".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jOTy8hqXC4KraP8&open=AZ2b8jOTy8hqXC4KraP8&pullRequest=338
Check warning on line 43 in Source/View/CardInputView/Subviews/JPSecurityMessageView.m
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPSecurityMessageView".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jGDy8hqXC4KraOS&open=AZ2b8jGDy8hqXC4KraOS&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPCardCustomizationTextInputCell".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jRuy8hqXC4KraQg&open=AZ2b8jRuy8hqXC4KraQg&pullRequest=338
sonarqubecloud / SonarCloud Code Analysis
Move this "declaration" out of "JPPaymentMethodsEmptyCardListCell".
See more on https://sonarcloud.io/project/issues?id=Judopay_JudoKit-iOS&issues=AZ2b8jM6y8hqXC4KraPs&open=AZ2b8jM6y8hqXC4KraPs&pullRequest=338