One command list in Settings, with a Palette column

[Juliusolsson05]

Settings had two lists of the same commands. This merges them into one.

Before	After
Keyboard Shortcuts — searchable, grouped by category, full command catalog	Commands and Shortcuts — same list, plus a Palette checkbox on the right
Command Picker Visibility — flat, unsearchable column of buttons	(deleted)

Why the keybinding list wins

It is built from the full command catalog, not the picker-filtered subset. So the merged list is itself the "show all commands" surface — a user who hid something finds it by searching Settings and re-ticking the box.

That is why this PR adds no reveal-all toggle and no bulk enable/disable. The merge removes the need for both. SHOW_HIDDEN_COMMANDS stays what it is: a programmatic escape hatch.

The column is Palette, never Enabled

Unticking hides the command from the picker list and nothing else. It stays executable by the chord shown on the same row, by the native menu, and by programmatic dispatch.

This naming is load-bearing. pickerVisibility.ts carries a READ-THIS block because treating picker visibility as an on/off switch already caused a real regression once: the File menu resolved ids against the picker-filtered registry, so commandVisibilityOverrides['new-tab'] = false — a cosmetic "tidy my palette" preference — silently killed File → New Tab.

Three row states, not two

• editable — ordinary checkbox
• excluded — — for commands the palette structurally never lists. The old list rendered a live switch here that persisted an override and could never change anything, because the registry filters the command out before visibility logic runs.
• group-suppressed — disabled + names the parent switch, for members of a disabled command group.

Correction. An earlier version of this description claimed the third state fixed a live defect — that Settings showed all six navigation commands as ON while the palette hid them. That was wrong, and the Codex reviewer caught it. At base 1e4f2d8f, resolveCommandVisible already delegated to isVisibleInPicker including commandGroup; that bug existed once and was fixed in an earlier PR. What this actually adds is smaller: those rows used to render an enabled, unticked checkbox whose click wrote an override the group gate silently outranked. Better affordance, not a correctness fix.

Cleanup

The write rule (prune the override when it equals the declared default) moves next to the read rule in pickerVisibility.ts, so both halves of one policy have one home. settingsRegistry.ts previously held the write rule inline and a second copy of the read rule. Both gone, along with listPickerCommandMeta and PickerCommandMeta, now dead.

Review

Two orchestrated reviewers — one Codex, one Claude. Both cleared the core: visibility never reaches an execution path, no command lost or gained a row, and the prune rule is correct for all eight tier/value combinations. Seven fixes applied:

1. Accessible name — the checkbox had none on any of 98 rows, and the suppressed state explained itself only via title on a control that is out of the tab order.
2. Settings search — deleting the old row deleted its search vocabulary, so typing hide / visibility into Settings returned nothing. Both vocabularies now live on the surviving row.
3. Duplicated rule — paletteState re-implemented the group gate as a literal 'navigation' test, which would not generalize to a second gated group. Extracted suppressingCommandGroup() as the single implementation; COMMAND_GROUP_LABELS is now Record<CommandGroup, string> so a new group is a compile error.
4. The false claim above.
5. Tests — setPickerVisibilityOverride shipped with none. Ten new cases cover both directions for every tier, a round-trip property against isVisibleInPicker, non-mutation, and the gate agreement.
6. hidden search token now covers group-suppressed rows, which ship suppressed by default and were the likeliest reason to search for it.
7. Sticky header inside the scroll container (outside, it drifted by the scrollbar width), and the orphaned JSX comment removed.

Verification

tsc clean on both projects (raw — electron-vite and vitest don't type-check), 1721 tests / 251 files green, check:keybindings OK.

Plan: docs/superpowers/plans/2026-07-28-unified-command-settings.md

🤖 Generated with Claude Code