Skip to content

ShipEffects: skip heavy Initialize for debris vessels #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonnyOThan merged 3 commits into from
May 8, 2026
Merged

ShipEffects: skip heavy Initialize for debris vessels #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97331a8
ShipEffects: skip heavy Initialize for debris vessels
bimo1d May 7, 2026
62a37a6
Drop onVesselTypeChange handler - no such GameEvent in KSP API
bimo1d May 7, 2026
c527e78
Merge branch 'master' into fix-shipeffects-debris-skip
JonnyOThan May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Source/RocketSoundEnhancement/ShipEffects.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ public bool Initialize()
return true;
}

// Debris vessels have no engines, no command modules — nothing useful to play sounds for.
if (vessel.vesselType == VesselType.Debris ||
vessel.vesselType == VesselType.SpaceObject ||
vessel.vesselType == VesselType.DroppedPart)
{
ignoreVessel = true;
return true;
}

audioParent = new GameObject($"ShipEffects_{vessel.vesselName}");
audioParent.transform.rotation = vessel.transform.rotation;
audioParent.transform.position = vessel.transform.position;
Expand Down