Fix direct outbound TUN loopback before inbound start - #3
Open
leekery wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Karing starts outbounds before the TUN inbound. During direct outbound startup,
InterfaceMonitor().MyInterfaces()can therefore still be empty, leavingmyAddressesunset. A packet routed todirectwhose destination is the TUN peer can then re-enter the TUN repeatedly. This was observed with UDP traffic to ports 5351 and 1900, but the fix intentionally protects the entire configured TUN range rather than hard-coding ports.For a TUN address of
10.20.0.1/30, the regression test verifies that10.20.0.2is rejected before the physical interface exists while192.168.1.254remains allowed.Related reports:
Testing
go test -tags with_karing ./protocol/direct ./adapter/inbound -count=1go vet -tags with_karing ./protocol/direct