Fix missing license text in published crates - #1031
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chosen MIT license stipulates that
but the
LICENSEfile is not included in published crates. This PR fixes that by symlinking the top-levelLICENSEfile from the workspace.Before:
After:
(The symbolic link is dereferenced and replaced with a regular file during publication as long as publication happens on a platform that understands symlinks. My understanding is that this mostly means not Windows-without-WSL. If that’s a concern, you could add duplicate copies of the
LICENSEfile instead. Most projects use symlinks.)