Only run parsing::instructions::tests::test_size on 64-bit targets - #1033
Merged
Merged
Conversation
Owner
Yeah let's do that I don't care about 32-bit targets |
musicinmybrain
force-pushed
the
32bit
branch
from
September 1, 2026 10:40
41b1d6d to
472744b
Compare
Contributor
Author
|
Ok, adjusted. |
musicinmybrain
force-pushed
the
32bit
branch
from
September 1, 2026 10:42
472744b to
c92d561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Fedora, we still build and test Rust library crates on
i686by default due to the existence of multilib packages forx86_64. The addition of#[cfg(any(target_pointer_width = "64", target_pointer_width = "32"))]to cover any other possible pointer widths is pedantic, since this crate will probably never be used on any other pointer width.An alternative, if you only care about checking the size on 64-bit targets, would be to guard the test with
and move on.