Skip to content

Only run parsing::instructions::tests::test_size on 64-bit targets - #1033

Merged
Keats merged 1 commit into
Keats:masterfrom
musicinmybrain:32bit
Sep 1, 2026
Merged

Keats merged 1 commit into
Keats:masterfrom
musicinmybrain:32bit

Conversation

@musicinmybrain

Copy link
Copy Markdown
Contributor

In Fedora, we still build and test Rust library crates on i686 by default due to the existence of multilib packages for x86_64. The addition of #[cfg(any(target_pointer_width = "64", target_pointer_width = "32"))] to cover any other possible pointer widths is pedantic, since this crate will probably never be used on any other pointer width.

An alternative, if you only care about checking the size on 64-bit targets, would be to guard the test with

// Expected size is based on a typical 64-bit target
#[cfg(any(target_pointer_width = "64"))]

and move on.

@Keats

Keats commented Sep 1, 2026

Copy link
Copy Markdown
Owner

An alternative, if you only care about checking the size on 64-bit targets,

Yeah let's do that I don't care about 32-bit targets

@musicinmybrain musicinmybrain changed the title Support 32-bit targets in parsing::instructions::tests::test_size Only run parsing::instructions::tests::test_size on 32-bit targets Sep 1, 2026
@musicinmybrain

Copy link
Copy Markdown
Contributor Author

Ok, adjusted.

@musicinmybrain musicinmybrain changed the title Only run parsing::instructions::tests::test_size on 32-bit targets Only run parsing::instructions::tests::test_size on 64-bit targets Sep 1, 2026
@Keats
Keats merged commit 7b67ed0 into Keats:master Sep 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants