Skip to content

Simulation configuration form - #142

Merged
bnmajor merged 2 commits into
mainfrom
sim-config-form
Aug 20, 2026
Merged

Simulation configuration form#142
bnmajor merged 2 commits into
mainfrom
sim-config-form

Conversation

@bnmajor

@bnmajor bnmajor commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Two fixes to the PHOLD simulation config form:

  1. Validation errors were never shown to the user. The form would be submitted but then be silently re-rendered on failure with no indication that there was an error or what the error was.
  2. Field ranges weren't fully aligned with the actual PHOLD constraints
    1. lookahead had no upper bound
    2. There was no check that mean stayed greater than lookahead
Screenshot from 2026-08-17 10-29-24

@bnmajor
bnmajor marked this pull request as ready for review August 17, 2026 17:23
marySalvi
marySalvi requested changes Aug 18, 2026
View reviewed changes

@marySalvi marySalvi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs the migration management and will depend on #141

@bnmajor
bnmajor requested a review from marySalvi August 19, 2026 15:10
@bnmajor
bnmajor disabled the stack merge August 20, 2026 14:12
@bnmajor
bnmajor disabled the stack merge August 20, 2026 18:50
Base automatically changed from save-simulation-config to main August 20, 2026 18:50
@bnmajor
bnmajor merged commit 030e625 into main Aug 20, 2026
2 checks passed
@bnmajor
bnmajor deleted the sim-config-form branch August 20, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marySalvi marySalvi marySalvi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bnmajor @marySalvi