Build before/after(:all) prefixes once per group in the TimeTracker#346
Open
connorshea wants to merge 2 commits into
Open
Build before/after(:all) prefixes once per group in the TimeTracker#346connorshea wants to merge 2 commits into
before/after(:all) prefixes once per group in the TimeTracker#346connorshea wants to merge 2 commits into
Conversation
…cker `add_hooks_time` re-derived the same `group_id_path[0..-2]` string for every (example, group) pair, and `reduce` over a hash allocates an array per pair. Build the prefixes once per group and sum with `each`. For 500 test files with 40 examples and 8 groups each: 356k allocations / 20.7 ms -> 9k / 8.8 ms. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merging the two `start_with?` checks into a single `if` left the two explanatory comments stacked above it, so neither one pointed at the branch it describes. Split them back apart with `next`, which also keeps the method's shape closer to what it replaced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AI Disclosure: This was generated using Claude Code with Opus 5. It has been tested and reviewed by me.
add_hooks_timere-derived the samegroup_id_path[0..-2]string for every(example, group)pair, andreduceover a hash allocates an array per pair. This PR builds the prefixes once per group and sums witheach.For 500 test files with 40 examples and 8 groups each: 356k allocations / 20.7 ms -> 9k / 8.8 ms.
Though it should be noted that this only happens when the split-by-example mode is enabled and actually gets used (when the Knapsack API marks a file as slow), and the benchmark is inherently unrealistic to show the scale of the change. In most test suites, this likely will not have much or any impact. If this change doesn't feel worth it due to the lack of impact for most users, it'd be fine with me to close it.
Checks
UNRELEASEDsection of theCHANGELOG.md, including the needed bump (i.e., patch, minor, major)lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and E2E tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and E2E tested.