[ARI:0001021, ARI:0001067] - mappings review - #82
Merged
Conversation
This review flagged five ids as wrong and wrote the negative SSSOM rows, but the ids stayed on the disease records, so the ontology still served them and the review grid would still offer them as unreviewed values: - ARI:0001073 Crohn's disease — ARI_UMLS C0156147 (that CUI is Crohn's colitis, NCIT:C35211; C0010346 remains) - ARI:0001074 Cryptogenic organizing pneumonia — ARI_NCI C35806, ARI_ICD10 J84.114, ARI_UMLS C0085786, ARI_MESH D000080203 Each disease gets a changelog entry naming what was removed. The manager does this automatically from now on (ARI-metadata-manager#151). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Pushed
Each disease carries a Cause: the manager stored confirmed ids on the disease but had no counterpart for flagged ones, so a flag wrote a row and a changelog line and left the id in place. Fixed in KrishnaTO/ARI-metadata-manager#151, which also removes ids for the flagged cells automatically on publish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curator comment:
Submitted via the ARI Metadata Manager by @KrishnaTO.
Reviewed mappings
1 confirmed, 5 flagged — 6 new row(s) added to
mappings/ari.sssom.tsv(SSSOM) andmappings/ari.equivalencies.tsv.Changes
No field-level differences detected versus the source branch.