Skip to content

Add Dockerfiles for core-service, token-service, and admin-portal - #93

Open
MohamadNazik wants to merge 1 commit into
LSFLK:mainfrom
MohamadNazik:feat/dockerfile-setup
Open

Add Dockerfiles for core-service, token-service, and admin-portal#93
MohamadNazik wants to merge 1 commit into
LSFLK:mainfrom
MohamadNazik:feat/dockerfile-setup

Conversation

@MohamadNazik

@MohamadNazik MohamadNazik commented Jul 30, 2026

Copy link
Copy Markdown

Purpose

Sets up Dockerfiles for the core-service, token-service, and admin-portal so the applications can be containerized and deployed on any container platform.

Goals

Provide production-ready container images for all three services, a docker-compose setup to verify them together locally, and a /health endpoint on core-service for liveness checks.

Approach

Added a multi-stage Dockerfile per service, a docker-compose.yml + .env.example to run all three locally against a MySQL instance, an entrypoint script for the admin-portal that injects runtime config via config.js, and a /health endpoint on core-service. Containers run as a non-root user and use restart: unless-stopped for resilience.

User stories

N/A

Release note

Add Docker image definitions for core-service, token-service, and admin-portal, enabling containerized deployment.

Documentation

N/A - no product documentation impact.

Training

N/A

Certification

N/A - no impact on certification exams.

Marketing

N/A

Automation tests

  • Unit tests

    No unit test changes; infrastructure-only change.

  • Integration tests

    Verified locally via docker-compose up that core-service, token-service, and admin-portal build and start correctly together against MySQL.

Security checks

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

Docker Desktop on Windows 11, docker-compose

Learning

N/A

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@MohamadNazik MohamadNazik changed the title Add Dockerfiles setup for Choreo deployment Add Dockerfiles for core-service, token-service, and admin-portal Jul 30, 2026
@MohamadNazik
MohamadNazik force-pushed the feat/dockerfile-setup branch 2 times, most recently from 8c87244 to 4958cb4 Compare July 31, 2026 04:42
Add Dockerfiles for token-service, core-service, and admin-portal.
Add docker-compose.yml + .env.example to verify all three locally
before deploying. Add a /health endpoint to core-service.

Upgrade Node to 24 and npm to patch bundled tar CVE in admin portal image

Simplify entrypoint since config.js is now provided via file mount

Run containers as non-root and fix restart resilience

Upgrade Node to 24 and npm to patch bundled tar CVE in admin portal image

Force LF line endings for shell scripts via .gitattributes

Windows checkouts with core.autocrlf=true were converting entrypoint.sh

fix(superapp-admin-portal) Added the actual config keys used in the code to entrypoint.sh

Make EXTERNAL_IDP_AUDIENCE optional

Skips audience validation when unset instead of crash-looping on startup.
@MohamadNazik
MohamadNazik force-pushed the feat/dockerfile-setup branch from 4958cb4 to c009470 Compare July 31, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant