Skip to content

[WIP] [Combat] Create a new global for all enfeeblement spells - #10923

Draft
Xaver-DaRed wants to merge 1 commit into
LandSandBoat:basefrom
Xaver-DaRed:enfeeblements
Draft

[WIP] [Combat] Create a new global for all enfeeblement spells#10923
Xaver-DaRed wants to merge 1 commit into
LandSandBoat:basefrom
Xaver-DaRed:enfeeblements

Conversation

@Xaver-DaRed

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

I've been 2 years threatening with this. Now it's starting.

Insert an actual description once I'm done.

Steps to test these changes

WIP

@Xaver-DaRed
Xaver-DaRed force-pushed the enfeeblements branch 11 times, most recently from 42ed9fc to 26262cb Compare July 28, 2026 22:53
@Butsuon

Butsuon commented Jul 31, 2026

Copy link
Copy Markdown

Just wanted to add, I noticed you nuked isGaze and isConal from acnitic burst. Are we still planning to eventually move AoE sizes/shapes/types into lua? One of the things I get asked by the nerds who know I creep the github is for me to audit BLU spells and it's a giant pain in the butt to cross reference both enum and sql for every spell.

@Xaver-DaRed

Copy link
Copy Markdown
Contributor Author

I removed nothing from it.
imagen

imagen

We just default to "not X" if not defined

@Butsuon

Butsuon commented Jul 31, 2026

Copy link
Copy Markdown

Ah, just a formatting change i didn't see at first glance.

image

If you just look at that, it looks like the lua layout changes and the params get nuked.

Anyway, my mistake aside. As i said, i often get asked questions like "can you tell me EXACTLY how <insert BLU spell> works?` and that's actually a somewhat difficult to answer question on LSB currently.

Or to put it another way, if we pretend SE just whole-hog changes Flying Hip Press to be Thundaga, making that change in the code is also a bit of a pain in the ass since the details about targeting, AoE type, and AoE size are in multiple places.

@github-actions github-actions Bot added the stale label Aug 25, 2026
@LandSandBoat LandSandBoat deleted a comment from github-actions Bot Aug 25, 2026
@sruon sruon added hold On hold, pending further action/info and removed stale labels Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants