[C++] [lua] Add equipment slot tracking to enchantment item usage, audit ring enchantments - #11093
Draft
Skold177 wants to merge 1 commit into
Draft
[C++] [lua] Add equipment slot tracking to enchantment item usage, audit ring enchantments#11093Skold177 wants to merge 1 commit into
Skold177 wants to merge 1 commit into
Conversation
Skold177
force-pushed
the
Enchantment-Rings-Audit
branch
from
August 11, 2026 00:38
577a501 to
767df1b
Compare
Contributor
Author
|
Don't 100% know if this is the best way to do it this, so opening as a draft for feedback, if we like it, i'll undraft! |
Skold177
force-pushed
the
Enchantment-Rings-Audit
branch
3 times, most recently
from
August 11, 2026 00:44
4e7d918 to
51bb86c
Compare
Adds equipment slot tracking to item usage, which is needed to implement enchantment items like Vision Ring & Mighty Ring properly.
Skold177
force-pushed
the
Enchantment-Rings-Audit
branch
from
August 11, 2026 01:05
51bb86c to
0879a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Sets up onItemUse and onItemUnequip to pass the equipment slot so that enchantments in the ring/earring slots stack and remove their effects properly. Also closes an edge case where a subType in the item effect could unintentionally be fed as a itemID (which is part of the reason this didn't work correctly to begin with)
Test included.
Steps to test these changes
!additem Armored Ring x2
/checkparam yourself
note defense
equip them both, see items stack
remove one, see one enchantment leave + lose 9 defense (1+ 8 from the enchantment)
remove the other