[lua] Implement Trial of the Magians job torque trials - #11138
Open
Davraena wants to merge 3 commits into
Open
Conversation
The Green Magian Moogle was a stub with no trial data behind it. Adds all 20 job trials (4424-4443) and wires it into the existing magian system. Take a trial at the moogle and it gives you the base neck piece inscribed with trial number; trade that plus the job's item to the Delivery Crate, then the piece back to the moogle for the augmented version. Only the first step needed new code, the rest already existed. Other changes: - magianMoogleInfo gains a minimum level and a trial-log key item, so those are no longer hardcoded to 75 - moogle can accept a MAGIAN_TRIAL_LOG but gives MAGIAN_LEARNERS_LOG only to players holding neither log - trials can declare a requiredJob. The main menu's sixth parameter masks out trials for jobs below that level - update and finish type 15, and finish type 5, are handled. Green uses different codes to the other moogles - taking a trial with a full inventory used to register it without giving the item, leaving it active and uncompletable textOffsets are from a retail capture by Wiggo: 1137 for trial 4424 through 1156 for 4443. https://drive.google.com/open?id=1BYy6tzKepCQ_9oo2AFmbWi8jhYk8-qAI Tested each torque end to end including the crate step, plus the level gating and list filtering, and the Orange moogle still works. Also fixes the zone in this NPC's !pos header, which said 64 not 243.
Xaver-DaRed
reviewed
Aug 14, 2026
| local function hasMagianLog(player, moogleData) | ||
| return player:hasKeyItem(moogleData[9]) or | ||
| (moogleData[10] ~= nil and player:hasKeyItem(moogleData[10])) | ||
| end |
Contributor
There was a problem hiding this comment.
no 1-liner functions. AI loves to use this, because it has infinite memory and doesnt care, but us humans dont have it, and abstracting a simple check only adds time to understand the logic
Contributor
Author
There was a problem hiding this comment.
Noted. Retested after changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Closes #8991.
Adds all 20 job torque trials (4424-4443) and wires it into the existing magian system.
textOffsets are from a retail capture by Wiggo: 1137 for trial 4424 through 1156 for 4443.
https://drive.google.com/open?id=1BYy6tzKepCQ_9oo2AFmbWi8jhYk8-qAI
Tested each torque end to end including the crate step, plus the level gating and list filtering, and the Orange moogle still works.
Also fixes the zone in this NPC's !pos header, which said 64 not 243.
Steps to test these changes
Also checked:
without granting a Learner's Log