[lua] [sql] Angra Mainyu fight behavior - #11212
Open
ThrisStraizo wants to merge 1 commit into
Open
Conversation
Xaver-DaRed
reviewed
Aug 22, 2026
Xaver-DaRed
reviewed
Aug 22, 2026
Xaver-DaRed
reviewed
Aug 22, 2026
Xaver-DaRed
reviewed
Aug 22, 2026
| if | ||
| teleportsLeft > 0 and | ||
| mob:getHPP() <= teleportThresholds[teleportIndex] and | ||
| not xi.combat.behavior.isEntityBusy(mob) |
Contributor
There was a problem hiding this comment.
this should be an early return, higher, before checking the other stuff
Xaver-DaRed
reviewed
Aug 22, 2026
Xaver-DaRed
reviewed
Aug 22, 2026
| mob:setMod(xi.mod.SPELLINTERRUPT, 100) | ||
| mob:setMobMod(xi.mobMod.MAGIC_COOL, 20) | ||
|
|
||
| mob:setLocalVar('[2hour]HPP', 25) |
Contributor
There was a problem hiding this comment.
why are you storing this in a local var if it isnt going to vary? use 25 directly in the 1 place its used
ThrisStraizo
force-pushed
the
dynamisspells
branch
from
August 22, 2026 01:29
cfdeae3 to
1a6f301
Compare
Xaver-DaRed
reviewed
Aug 23, 2026
| if | ||
| teleportsLeft > 0 and | ||
| hpPercent <= teleportThresholds[teleportIndex] and | ||
| not xi.combat.behavior.isEntityBusy(mob) |
Contributor
There was a problem hiding this comment.
What I meant is that this should go first so we dont havre to fetch all those vars and data if not needed.
if xi.combat.behavior.isEntityBusy(mob) then
return
end
-- Whatever else
Contributor
There was a problem hiding this comment.
yeah, but then you have to remove it from here. Also, dont remove the return that was inside here
ThrisStraizo
force-pushed
the
dynamisspells
branch
from
August 23, 2026 02:08
1a6f301 to
28975d2
Compare
Xaver-DaRed
reviewed
Aug 23, 2026
| then | ||
| mob:castSpell(xi.magic.spell.GRAVIGA, target) | ||
| mob:setLocalVar('teleportsLeft', teleportsLeft - 1) | ||
| end |
Contributor
There was a problem hiding this comment.
like i said above, dont remove the return that was here. And also, do remove the extra check. if we have gotten here, its impossible for the mob to be busy
This PR fixes Angra Mainyu's fight behavior, teleportation, and spells.
ThrisStraizo
force-pushed
the
dynamisspells
branch
from
August 23, 2026 02:58
28975d2 to
f3146ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR fixes Angra Mainyu's fight behavior, teleportation, and spells.
https://youtu.be/0LVWrRLOeg8
https://youtu.be/XWcoK3kv9OQ
Steps to test these changes
Spawn Angra Mainyu and watch him Graviga based on HP triggers, then teleport.
Then watch him spam Death on you after using chainspell yeah!