Skip to content

[lua] [sql] Implement data-backed break rates for NQ/HQ HELM gear - #11224

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:helm_break_rates
Aug 23, 2026
Merged

[lua] [sql] Implement data-backed break rates for NQ/HQ HELM gear#11224
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:helm_break_rates

Conversation

@WinterSolstice8

@WinterSolstice8 WinterSolstice8 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

tl;dr: implement the HELM gear break rate reduction from Sruons data

Torque and Rope are probably not quite right, however.

Steps to test these changes

Bust out the calculator with prints in doesToolBreak before and after break chance is modified

@LandSandBoat LandSandBoat deleted a comment from github-actions Bot Aug 23, 2026
@WinterSolstice8
WinterSolstice8 marked this pull request as ready for review August 23, 2026 01:54
Comment thread scripts/globals/hobbies/helm/logic.lua Outdated
Comment thread data/enums/mod.yaml Outdated
Comment thread scripts/globals/hobbies/helm/logic.lua Outdated
Torque and Rope are probably not quite right, however.
@Xaver-DaRed
Xaver-DaRed enabled auto-merge August 23, 2026 02:45
@Xaver-DaRed
Xaver-DaRed merged commit bf93524 into LandSandBoat:base Aug 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants