fix(security): bump brace-expansion and fast-uri to remediate Veracode SCA flaws - #77
Merged
Merged
Conversation
…e SCA flaws - brace-expansion 2.1.3 -> 2.1.4: backports the fix for incomplete maxLength bounding. The comma-alternative accumulator and padded-sequence generation are now bounded before combine() runs, closing an out-of-memory / event-loop-stall DoS that a crafted brace pattern could trigger even on the previously "fixed" 2.1.3. - fast-uri 3.1.4 -> 3.1.5: fixes a backslash authority-delimiter parsing desync vs Node's WHATWG URL, where fast-uri treated "\\", "/\", "\/" as part of the path instead of the host, letting host-based allow/deny checks be bypassed by a URL Node itself would resolve to a different host. Both stay within the major versions already required by minimatch/ajv, so no downstream changes were needed. Verified via a full workspace build, typedoc doc generation (exercises minimatch -> brace-expansion), and the lf-js-utils unit suite (368/368 passing). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
shiyuanzhao-lf
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brace-expansionpnpm override from^2.1.3to^2.1.4, backporting the fix for incompletemaxLengthbounding. The comma-alternative accumulator and padded-sequence generation are now bounded beforecombine()runs, closing an out-of-memory / event-loop-stall DoS a crafted brace pattern could still trigger on 2.1.3.fast-uripnpm override from^3.1.4to^3.1.5, fixing a backslash authority-delimiter parsing desync vs Node's WHATWG URL where backslash-based delimiters were folded into the path instead of being treated as the host delimiter, letting host-based allow/deny checks be bypassed.minimatch/ajv(only devDependency consumers), so no consumer code changes were needed. Bumpingbrace-expansionstraight to its 5.x latest was avoided deliberately: 5.x switched from a CJS default export to a namedexpandexport, which breaksminimatch'srequire('brace-expansion')usage.Test plan
pnpm installregeneratespnpm-lock.yamlwith only the two target packages changedpnpm buildsucceeds across all workspace packagespnpm --filter @laserfiche/lf-js-utils testpasses (368/368)pnpm generate-docs(exercisestypedoc->minimatch->brace-expansion) completes without error, confirming the CJS export shape still worksGenerated with Claude Code