feat: migrate to CompositionBuilder.Share<T>(), bump to 0.9.0-preview.90 - #77
Merged
Merged
Conversation
Adds builder.Share<Meter>() to DynamoDbDistributedLockCompositionDefaults and removes [Shared] Meter meter (and the now-superfluous meter parameter itself, since Share<T>() needs no retrieval parameter) from all 13 occurrences across DynamoDbDistributedLockTests.cs and ExponentialBackoffRetryPolicyTests.cs. The unrelated [Shared] IAmazonDynamoDB dynamo usage is untouched. metricAggregator continues to observe the exact Meter instance ILockMetrics publishes to. Bumps Compono/Compono.XunitV3/Compono.TestDoubles to the real published 0.9.0-preview.90 (ADR-0056/PLAN-0056, LayeredCraft/compono#117). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MEj38a2y3jipmp8w8L2Bnj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builder.Share<Meter>()toDynamoDbDistributedLockCompositionDefaultsand removes[Shared] Meter meter— plus themeterparameter itself, sinceShare<T>()needs no retrieval parameter to establish identity — from all 13 occurrences acrossDynamoDbDistributedLockTests.csandExponentialBackoffRetryPolicyTests.cs. The unrelated[Shared] IAmazonDynamoDB dynamousage is untouched.metricAggregatorcontinues to observe the exactMeterinstanceILockMetricspublishes to — the migration is observably invisible except for the removed attribute/parameter.Compono/Compono.XunitV3/Compono.TestDoublesto the real, published0.9.0-preview.90(ADR-0056/PLAN-0056, LayeredCraft/compono#117).Test plan
dotnet restoreagainst the real published0.9.0-preview.90(not a local dogfood feed)dotnet build -c Release— 0 errors, 0 warningsdotnet test -c Release— 180 total, 0 failed🤖 Generated with Claude Code