Skip to content

chore(github): align .github config with compono, drop unused templates - #396

Merged
ncipollina merged 4 commits into
mainfrom
chore/github-align-with-compono
Sep 4, 2026
Merged

chore(github): align .github config with compono, drop unused templates#396
ncipollina merged 4 commits into
mainfrom
chore/github-align-with-compono

Conversation

@ncipollina

Copy link
Copy Markdown
Collaborator

📋 Summary

Cross-repo audit of .github between minimal-lambda and compono. Ports a handful of security/behavior fixes from compono into minimal-lambda's config and removes unused GitHub templates. Most workflow differences (pr-build.yaml, docs.yaml, publish-*.yaml, package/aot-validation) are intentional divergence and were left untouched — documented in .github/CLAUDE.md.

📝 Changes

  • dependabot-auto-merge.yml: SHA-pin third-party actions, switch from secrets.GITHUB_TOKEN to a GitHub App token for approve/merge, scope the trigger to this repo, and gate the approve step on update-type (was previously ungated).
  • dependabot.yml: adopt compono's multi-ecosystem-groups/cooldown/weekly-Wednesday scheduling structure for the github-actions/npm/dotnet-sdk/pip ecosystems. nuget's own ignore rules and ecosystem list (npm/dotnet-sdk/pip, not in compono) are unchanged — this repo's actual dependency needs differ from compono's.
  • release-drafter.yml: autolabeler regex now matches a trailing ! (e.g. feat!:) for breaking-change titles, matching compono; version-resolver blocks switched to the labels: list syntax.
  • Removed ISSUE_TEMPLATE/, DISCUSSION_TEMPLATE/, and pull_request_template.md — unused, and compono doesn't carry them either. Dropped the now-stale reference to pull_request_template.md from .github/AGENTS.md (symlinked to .github/CLAUDE.md).

🧪 Validation

  • Reviewed diffs against compono's .github file by file.
  • YAML structure checked by eye against dependabot/release-drafter schema; no CI run yet for the dependabot.yml or release-drafter.yml changes since those only fire on their own schedule/PR events.

⚠️ Breaking Changes

dependabot-auto-merge.yml now requires DEPENDABOT_AUTOMERGE_APP_ID and DEPENDABOT_AUTOMERGE_PRIVATE_KEY secrets on this repo (matching compono's setup) — auto-merge/auto-approve will silently fail on the next Dependabot PR until those are added if they aren't already present.

💬 Notes for Reviewers

Please confirm DEPENDABOT_AUTOMERGE_APP_ID/DEPENDABOT_AUTOMERGE_PRIVATE_KEY secrets exist on this repo before merging, or the auto-merge workflow will break.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qn9kagNWsCubTrnzN6NEqV

ncipollina and others added 2 commits September 3, 2026 22:35
Ports compono's hardened dependabot auto-merge (SHA-pinned actions, GitHub
App token, repo scoping), dependabot.yml's multi-ecosystem-group/cooldown
structure, and release-drafter.yml's bang-matching autolabel regex, found
during a cross-repo .github audit. Also removes ISSUE_TEMPLATE,
DISCUSSION_TEMPLATE, and pull_request_template.md, which weren't in use.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn9kagNWsCubTrnzN6NEqV
The template-removal commit picked up the deletions but missed these
already-edited files (dependabot.yml, release-drafter.yml,
dependabot-auto-merge.yml, AGENTS.md), which were still unstaged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn9kagNWsCubTrnzN6NEqV
@github-actions github-actions Bot added the type: chore Maintenance task label Sep 4, 2026
…m-group entries

Dependabot rejected the config: '#/updates/1/patterns' is required when
'multi-ecosystem-group' is set. Missed this field porting compono's
multi-ecosystem-groups structure.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn9kagNWsCubTrnzN6NEqV

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 888229f502

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/AGENTS.md
…ENTS.md

Codex review on #396 caught it: the root AGENTS.md still pointed PR authors
at ./.github/pull_request_template.md after that file was deleted earlier
in this PR.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn9kagNWsCubTrnzN6NEqV

@j-d-ha j-d-ha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncipollina
ncipollina merged commit f779f6e into main Sep 4, 2026
5 checks passed
@ncipollina
ncipollina deleted the chore/github-align-with-compono branch September 4, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Maintenance task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants