refactor(calendar): replace subscription link with button - #1660
Open
lucs7 wants to merge 1 commit into
Open
Conversation
lucs7
force-pushed
the
feature/ics-rework/button-link
branch
from
August 23, 2026 09:57
703f703 to
f8bac08
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors calendar subscription controls from links to native buttons for proper disabled-state handling during refreshes.
Changes:
- Replaced subscription anchors with buttons in both templates.
- Updated JavaScript to use the native
disabledproperty. - Removed obsolete anchor-specific CSS.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Web/scripts/calendar.js |
Disables the subscription button during refreshes. |
Web/css/librebooking.css |
Removes obsolete anchor-disabled styling. |
tpl/Calendar/mycalendar.subscription.tpl |
Uses a button for personal calendar subscriptions. |
tpl/Calendar/calendar.subscription.tpl |
Uses a button for calendar subscriptions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
labmecanicatec
approved these changes
Aug 23, 2026
labmecanicatec
left a comment
Collaborator
There was a problem hiding this comment.
I think it's appropriate to change the title attribute in tpl/Admin/Resources/manage_resources_public.tpl lines 17 and 22 to {translate key=SubscribeToCalendar}
lucs7
force-pushed
the
feature/ics-rework/button-link
branch
from
August 28, 2026 19:07
f8bac08 to
46a1ad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @labmecanicatec suggestion follow up to #1644
This pull request refactors the calendar subscription UI to use a
<button>element instead of an<a>tag for the "Subscribe to Calendar" action. This change improves accessibility and ensures proper disabling of the button while new calendar data is loading. Related CSS and JavaScript logic have been updated to match this new approach