Skip to content

refactor(calendar): replace subscription link with button - #1660

Open
lucs7 wants to merge 1 commit into
LibreBooking:developfrom
lucs7:feature/ics-rework/button-link
Open

refactor(calendar): replace subscription link with button #1660
lucs7 wants to merge 1 commit into
LibreBooking:developfrom
lucs7:feature/ics-rework/button-link

Conversation

@lucs7

@lucs7 lucs7 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Based on @labmecanicatec suggestion follow up to #1644

This pull request refactors the calendar subscription UI to use a <button> element instead of an <a> tag for the "Subscribe to Calendar" action. This change improves accessibility and ensures proper disabling of the button while new calendar data is loading. Related CSS and JavaScript logic have been updated to match this new approach

Copilot AI lite review requested due to automatic review settings August 23, 2026 09:54
@lucs7
lucs7 force-pushed the feature/ics-rework/button-link branch from 703f703 to f8bac08 Compare August 23, 2026 09:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors calendar subscription controls from links to native buttons for proper disabled-state handling during refreshes.

Changes:

  • Replaced subscription anchors with buttons in both templates.
  • Updated JavaScript to use the native disabled property.
  • Removed obsolete anchor-specific CSS.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Web/scripts/calendar.js Disables the subscription button during refreshes.
Web/css/librebooking.css Removes obsolete anchor-disabled styling.
tpl/Calendar/mycalendar.subscription.tpl Uses a button for personal calendar subscriptions.
tpl/Calendar/calendar.subscription.tpl Uses a button for calendar subscriptions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@labmecanicatec labmecanicatec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's appropriate to change the title attribute in tpl/Admin/Resources/manage_resources_public.tpl lines 17 and 22 to {translate key=SubscribeToCalendar}

@lucs7
lucs7 force-pushed the feature/ics-rework/button-link branch from f8bac08 to 46a1ad1 Compare August 28, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants