Feature/ics rework/invitees - #1673
Draft
lucs7 wants to merge 2 commits into
Draft
Conversation
Added mime-type to ics attachment to improve RFC 5546 compliance and client event recognition. Added mime-type specific tests.
Reservation ICS attachments were always sent with METHOD:REQUEST regardless of what the email actually represented, and iCalendarReservationView never populated attendee data at all: ReservationItemView had no email fields for participants/invitees, so Attendees was always empty and REQUEST/CANCEL never had anything to act on. ReservationItemView now tracks ParticipantEmails/InviteeEmails (from the participant_list/invitee_list query and FromReservationView()), and iCalendarReservationView builds an Attendees list from participants, invitees, and guests, rendered as ATTENDEE properties by CalendarExportDisplay. ReservationEmailMessage subclasses now declare their iTip intent via a GetIcsMethod() hook: - PUBLISH by default, since ReservationCreatedEmail/UpdatedEmail/ ApprovedEmail and ReservationShareEmail send their attachment to the reservation owner or an arbitrary share recipient, never to one of the reservation's own attendees. A METHOD:REQUEST addressed to someone who isn't listed as an ATTENDEE doesn't make sense, even though the attachment still lists attendees informationally. - CANCEL for ReservationDeletedEmail (and GuestDeletedEmail/ InviteeRemovedEmail/ParticipantDeletedEmail). - REQUEST for InviteeAddedEmail/GuestAddedEmail (and their Updated/Participant subclasses), which genuinely are addressed to the attendee being asked to accept/decline. CalendarExportDisplay::DetermineMethod() keeps its own attendee-based REQUEST/PUBLISH heuristic for the direct export/subscription pages, which is a separate concern from what an email attachment's recipient is. Assisted-by: Claude:claude-sonnet-4-6 BREAKING CHANGE: ICS METHOD in email attachments is no longer always REQUEST. Owner/share emails now use PUBLISH, cancellation emails use CANCEL, and only invitee/guest/participant added emails send REQUEST. Attendee data (ATTENDEE properties) was previously always empty; it is now populated from participants, invitees, and guests. The sender address changes to the configured default (no @no-reply fallback).
lucs7
force-pushed
the
feature/ics-rework/invitees
branch
from
August 28, 2026 21:06
b98c43a to
8f811bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements several improvements related to calendar export, attendee handling, and email attachment functionality. The main focus is on supporting accurate attendee lists in iCalendar (ICS) exports and emails, ensuring correct calendar method usage (REQUEST, PUBLISH, CANCEL), and allowing email attachments to specify MIME types. This enhances interoperability with calendar clients and improves the accuracy of scheduling emails.
@JohnVillalovos could you please test this in outlook
I tested it on Thunderbird and Gmail
depends-on: #1657