Skip to content

[codex] Split MarketDataRouter public headers - #157

Merged
LimiNode merged 1 commit into
mainfrom
refactor/market-data-router-decomposition
Sep 3, 2026
Merged

[codex] Split MarketDataRouter public headers#157
LimiNode merged 1 commit into
mainfrom
refactor/market-data-router-decomposition

Conversation

@LimiNode

@LimiNode LimiNode commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • split the public Router identifiers into MarketDataRouterIds.hpp
  • split the move-only RAII handle into MarketDataRouterSubscription.hpp
  • keep market_data.hpp as the stable aggregate include and leave Router state implementation private in .ipp
  • consolidate duplicated tick/bar subscription lifecycle and batch delivery logic in detail helpers

Verification

  • market_data_router_test: 21/21 passed
  • market_data_hub_test: 4/4 passed
  • market_data_subscription_contract_test: 22/22 passed
  • market_data_subscriber_base_test and example passed in Ubuntu CI
  • Router example passed in Ubuntu CI
  • g++ -std=c++17 -Iinclude -fsyntax-only examples/market_data_router_example.cpp
  • git diff --check

The local SubscriberBase build was initially blocked by a mixed local dependency artifact set; clean Ubuntu and Windows CI passed the complete affected suite.

@LimiNode
LimiNode marked this pull request as ready for review September 3, 2026 10:29
@LimiNode
LimiNode merged commit 20f3bf0 into main Sep 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant