[codex] Split MarketDataRouter public headers - #157
Merged
Conversation
LimiNode
marked this pull request as ready for review
September 3, 2026 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarketDataRouterIds.hppMarketDataRouterSubscription.hppmarket_data.hppas the stable aggregate include and leave Router state implementation private in.ippVerification
market_data_router_test: 21/21 passedmarket_data_hub_test: 4/4 passedmarket_data_subscription_contract_test: 22/22 passedmarket_data_subscriber_base_testand example passed in Ubuntu CIg++ -std=c++17 -Iinclude -fsyntax-only examples/market_data_router_example.cppgit diff --checkThe local SubscriberBase build was initially blocked by a mixed local dependency artifact set; clean Ubuntu and Windows CI passed the complete affected suite.