Skip to content

feat: Add POIDraft for Apex Legends - #7808

Open
SlothyMan wants to merge 18 commits into
mainfrom
SlothymanPOI
Open

feat: Add POIDraft for Apex Legends#7808
SlothyMan wants to merge 18 commits into
mainfrom
SlothymanPOI

Conversation

@SlothyMan

@SlothyMan SlothyMan commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

This module was for some time already live in Apex. I just tried to update it to table2 and now moving to GH

Module usage can be viewed here
https://liquipedia.net/apexlegends/Apex_Legends_Global_Series/2026/Split_1/Playoffs/POI_Drafts

image image image image

Mobile:
image

How did you test this change?

live

@SlothyMan
SlothyMan requested review from a team as code owners July 13, 2026 15:36
@SlothyMan SlothyMan added the g: apex Apex Legends label Jul 13, 2026
@Rathoz Rathoz changed the title feat:Add POIDraft for Apex Legends feat: Add POIDraft for Apex Legends Jul 27, 2026
@SlothyMan
SlothyMan requested a review from Rathoz August 21, 2026 13:09

@ElectricalBoy ElectricalBoy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all widget2 impls should be converted to widget3 before merge

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting this under the Widget/ directory feels wrong

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to check the widget3 thing. If I understand correctly then data I should move just to apexlegends/POIDraft/POIMAP/Data.lua ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds better than putting it under Widget/ directory

@hjpalpha hjpalpha Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use the structure from the rfc already?

https://docs.google.com/document/d/1VX9_-PodeTx4fUI4PYugYrmUFSF7B4FdySQqzvKOx2U/edit?tab=t.0#heading=h.7dziadxyui75

fwiw personally i think for features that are completely wiki specific we should drop the custom. but the rest should still be applicable

This file contains the data structure for various maps and points of interest (POIs) in the game Apex Legends, including their coordinates, mobile names, and date boundaries.
Refactor POIMap to use Helpers for filtering and rendering.
Refactor PoiDraft to use Helpers for row rendering and convert to functional component.
Added type annotations for PoiMapComponent methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

g: apex Apex Legends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants