feat: Add mitmproxy to the devcontainer

[Rathoz]

What

Installs mitmproxy in the devcontainer and forwards port 8080, so scripts/proxy_lp.py can serve locally built CSS and JS into the live wiki as described on the Local Development Setup wiki page.

The CA lives in a volume so the certificate only has to be trusted in the browser once, rather than after every rebuild.

Stacked on #7955 — that one should merge first.

How it was tested

In the container: npm run build, then started python scripts/proxy_lp.py and requested through it —

• liquipedia.net/commons/load.php?only=styles returned Via: HTTP/1.1 LiquipediaMapper and matched lua/output/css/main.css byte-for-byte
• ...?only=scripts matched lua/output/js/main.js byte-for-byte
• ~/.mitmproxy/mitmproxy-ca-cert.pem generated in the volume
• npm run lua-test still 761 successes / 0 failures

Not tested: the host-side port forward, which is a VS Code Dev Containers feature the CLI does not set up the same way. The proxy was verified from inside the container only.

[Copilot]

Pull request overview

Adds mitmproxy support to the repository devcontainer so contributors can run scripts/proxy_lp.py to serve locally built CSS/JS into the live Liquipedia site during development.

Changes:

• Install a pinned mitmproxy version into the devcontainer’s Python venv.
• Persist mitmproxy’s CA state across rebuilds via a dedicated named volume.
• Forward port 8080 and document the local proxy workflow in the README.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
README.md	Documents the mitmproxy-based workflow for previewing locally built CSS/JS on the live wiki.
.devcontainer/post-create.sh	Adjusts ownership for the new ~/.mitmproxy named volume alongside node_modules.
.devcontainer/Dockerfile	Installs mitmproxy (pinned) into the devcontainer Python venv at image build time.
.devcontainer/devcontainer.json	Adds a named volume for ~/.mitmproxy and forwards port 8080 with port metadata.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[ElectricalBoy]

mitmproxy is kept out of requirements.txt, which covers the deploy scripts rather than optional local tooling

since python dependencies that our GHA workflows use are cached via actions/setup-python step anyway, I don't think it hurts as much to add mitmproxy to requirements.txt

[Eetwalt]

Tested on Linux (Arch, Docker 29.7.2, devcontainer CLI 0.87.0, no VS Code). Two issues.

forwardPorts doesn't publish the port outside VS Code

It's an editor-side tunnel, not a container property, so plain devcontainer up never passes -p and the container ends up with PortBindings: {}. With the proxy running, 127.0.0.1:8080 on the host is refused while the container IP on 8080 answers, so the README's "forwarded to 127.0.0.1:8080 on your host" only holds in VS Code.

Adding appPort next to forwardPorts fixes it (verified: docker port shows 8080/tcp -> 127.0.0.1:8080, and mitm.it plus intercepted HTTPS then work from a host browser):

"appPort": [
	"127.0.0.1:8080:8080"
],

Worth spelling out the loopback bind rather than the bare "appPort": [8080], which publishes on all interfaces and would leave an open forward proxy reachable from the local network.

Without a build, the proxy silently does nothing

post-create.sh never builds, so on a fresh container lua/output/css/main.css doesn't exist and LiquipediaMapper passes the request through to the real server with no Via header and no log line. Following README steps 1 to 3 you set up the proxy, trust the cert, load a page, see nothing change, and get no diagnostics, since npm run build only appears at step 4 as part of the edit-refresh loop.

Adding npm run build to post-create.sh is the cheap fix; logging the missing file in the addon is the sturdier one. Existing proxy_lp.py behaviour rather than something this PR introduces, but this PR is what puts it in front of people who've never built the repo.

[Rathoz]

Both confirmed and fixed.

appPort — verified: docker port now reports 8080/tcp -> 127.0.0.1:8080 and a request from the host reaches the proxy. Took your explicit loopback form for the reason you gave. This was the one thing I called out as untested when opening the PR, so thanks for closing it properly. One tradeoff worth noting for reviewers: appPort hard-binds the host port at creation, so if something else already holds 8080 the container will not start, where VS Code would have quietly picked another port. For a proxy that needs a predictable port that seems the right trade.

Silent no-op — worse than it looked. The reason nothing is logged is that proxy_lp.py builds its own Master from default_addons(), which contains no TermLog, so every addon error goes nowhere, not just this one. Fixed both halves you suggested: post-create.sh now builds, and the mapper reports which file is missing instead of failing mutely:

LiquipediaMapper: [Errno 2] No such file or directory: 'lua/output/css/main.css'. Run npm run build first.

Also moved npm run build to step 1 in the README rather than leaving it at the end of the edit loop. Happy path re-verified: CSS and JS still served byte-for-byte with the Via header.

I left adding TermLog out of this PR, since it changes output for existing proxy users beyond what was reported, but it is a one-liner and probably worth doing separately — as it stands any future error in that addon is invisible.