Skip to content

refactor(match2): deprecate createbody - #7969

Open
Rathoz wants to merge 8 commits into
mainfrom
m2-ms-depricated-createBody
Open

refactor(match2): deprecate createbody#7969
Rathoz wants to merge 8 commits into
mainfrom
m2-ms-depricated-createBody

Conversation

@Rathoz

@Rathoz Rathoz commented Aug 16, 2026

Copy link
Copy Markdown
Member

Summary

Deprecate CreateBody in MatchSummary, and move the main usages to a new CreateGames. Additional refactors around this is planned

How did you test this change?

@Rathoz
Rathoz force-pushed the m2-ms-depricated-createBody branch from 5a09146 to 2a7148d Compare August 17, 2026 09:03
@hjpalpha hjpalpha changed the title refactor(match2): depricate createbody refactor(match2): deprecate createbody Aug 17, 2026
@Rathoz
Rathoz force-pushed the m2-ms-depricated-createBody branch from 29e8c84 to be916bb Compare August 17, 2026 09:07
@Rathoz
Rathoz marked this pull request as ready for review August 17, 2026 18:49
@Rathoz
Rathoz requested review from a team as code owners August 17, 2026 18:49
Copilot AI lite review requested due to automatic review settings August 17, 2026 18:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the MatchSummary customization API to deprecate createBody and shift primary customization to createGames/createGame, while centralizing common body elements (MVP, map veto, bans) in the shared base implementation.

Changes:

  • Deprecates createBody in MatchSummary/Base and adds createGames to the custom interface.
  • Updates MatchSummary/Base default body creation to optionally use createGames, and to build/render the character bans table via a new maxBans option.
  • Refactors multiple wiki-specific MatchSummary.lua implementations to use createGames/createGame and pass maxBans via defaultGetByMatchId options.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
lua/wikis/wildrift/MatchSummary.lua Removes createBody, switches to createGame, passes maxBans to base.
lua/wikis/smite/MatchSummary.lua Removes createBody, switches to createGame, passes maxBans to base.
lua/wikis/smash/MatchSummary.lua Replaces createBody with createGames to integrate with base default body.
lua/wikis/pokemon/MatchSummary.lua Removes createBody, switches to createGame, passes maxBans to base.
lua/wikis/overwatch/MatchSummary.lua Replaces createBody with createGames, passes maxBans to base.
lua/wikis/mobilelegends/MatchSummary.lua Replaces createBody with createGames, passes maxBans to base.
lua/wikis/leagueoflegends/MatchSummary.lua Replaces createBody with createGames, passes maxBans to base.
lua/wikis/lab/MatchSummary.lua Replaces createBody with createGames to integrate with base default body.
lua/wikis/honorofkings/MatchSummary.lua Replaces createBody with createGames, passes maxBans to base.
lua/wikis/heroes/MatchSummary.lua Formatting-only change (blank line).
lua/wikis/fighters/MatchSummary.lua Renames createBody to createGames to integrate with base default body.
lua/wikis/easportsfc/MatchSummary.lua Renames createBody to createGames and adjusts renderable typing / opponent struct.
lua/wikis/dota2/MatchSummary.lua Replaces createBody with createGames, passes maxBans to base.
lua/wikis/deadlock/MatchSummary.lua Replaces createBody with createGames, passes maxBans to base.
lua/wikis/commons/MatchSummary/Base.lua Adds createGames API + maxBans option; default body now can render bans table and use createGames.
lua/wikis/brawlhalla/MatchSummary.lua Replaces createBody with createGames and updates return typing.
lua/wikis/ageofempires/MatchSummary.lua Renames createBody to createGames to integrate with base default body.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lua/wikis/commons/MatchSummary/Base.lua
Comment thread lua/wikis/dota2/MatchSummary.lua Outdated
Comment thread lua/wikis/mobilelegends/MatchSummary.lua Outdated
Comment thread lua/wikis/overwatch/MatchSummary.lua Outdated
Comment thread lua/wikis/deadlock/MatchSummary.lua Outdated
Comment thread lua/wikis/lab/MatchSummary.lua Outdated
Comment thread lua/wikis/honorofkings/MatchSummary.lua Outdated
Comment thread lua/wikis/smash/MatchSummary.lua Outdated
Comment thread lua/wikis/commons/MatchSummary/Base.lua Outdated
@Rathoz
Rathoz force-pushed the m2-ms-depricated-createBody branch from be66419 to 144ad8a Compare August 18, 2026 10:56
@Rathoz
Rathoz requested a review from ElectricalBoy August 18, 2026 11:17
@hjpalpha

Copy link
Copy Markdown
Collaborator

fwiw this does not include craft wikis createBody, which assume is intended

@Rathoz

Rathoz commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

fwiw this does not include craft wikis createBody, which assume is intended

Only about half of the create Body were changed in this PR. Hence the deprecation, and not deletion/replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants