refactor(match2): deprecate createbody - #7969
Open
Rathoz wants to merge 8 commits into
Open
Conversation
Rathoz
force-pushed
the
m2-ms-depricated-createBody
branch
from
August 17, 2026 09:03
5a09146 to
2a7148d
Compare
Rathoz
force-pushed
the
m2-ms-depricated-createBody
branch
from
August 17, 2026 09:07
29e8c84 to
be916bb
Compare
Rathoz
marked this pull request as ready for review
August 17, 2026 18:49
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MatchSummary customization API to deprecate createBody and shift primary customization to createGames/createGame, while centralizing common body elements (MVP, map veto, bans) in the shared base implementation.
Changes:
- Deprecates
createBodyinMatchSummary/Baseand addscreateGamesto the custom interface. - Updates
MatchSummary/Basedefault body creation to optionally usecreateGames, and to build/render the character bans table via a newmaxBansoption. - Refactors multiple wiki-specific
MatchSummary.luaimplementations to usecreateGames/createGameand passmaxBansviadefaultGetByMatchIdoptions.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/wildrift/MatchSummary.lua | Removes createBody, switches to createGame, passes maxBans to base. |
| lua/wikis/smite/MatchSummary.lua | Removes createBody, switches to createGame, passes maxBans to base. |
| lua/wikis/smash/MatchSummary.lua | Replaces createBody with createGames to integrate with base default body. |
| lua/wikis/pokemon/MatchSummary.lua | Removes createBody, switches to createGame, passes maxBans to base. |
| lua/wikis/overwatch/MatchSummary.lua | Replaces createBody with createGames, passes maxBans to base. |
| lua/wikis/mobilelegends/MatchSummary.lua | Replaces createBody with createGames, passes maxBans to base. |
| lua/wikis/leagueoflegends/MatchSummary.lua | Replaces createBody with createGames, passes maxBans to base. |
| lua/wikis/lab/MatchSummary.lua | Replaces createBody with createGames to integrate with base default body. |
| lua/wikis/honorofkings/MatchSummary.lua | Replaces createBody with createGames, passes maxBans to base. |
| lua/wikis/heroes/MatchSummary.lua | Formatting-only change (blank line). |
| lua/wikis/fighters/MatchSummary.lua | Renames createBody to createGames to integrate with base default body. |
| lua/wikis/easportsfc/MatchSummary.lua | Renames createBody to createGames and adjusts renderable typing / opponent struct. |
| lua/wikis/dota2/MatchSummary.lua | Replaces createBody with createGames, passes maxBans to base. |
| lua/wikis/deadlock/MatchSummary.lua | Replaces createBody with createGames, passes maxBans to base. |
| lua/wikis/commons/MatchSummary/Base.lua | Adds createGames API + maxBans option; default body now can render bans table and use createGames. |
| lua/wikis/brawlhalla/MatchSummary.lua | Replaces createBody with createGames and updates return typing. |
| lua/wikis/ageofempires/MatchSummary.lua | Renames createBody to createGames to integrate with base default body. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rathoz
force-pushed
the
m2-ms-depricated-createBody
branch
from
August 18, 2026 10:56
be66419 to
144ad8a
Compare
hjpalpha
approved these changes
Aug 18, 2026
Collaborator
|
fwiw this does not include craft wikis createBody, which assume is intended |
Member
Author
Only about half of the create Body were changed in this PR. Hence the deprecation, and not deletion/replacement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate CreateBody in MatchSummary, and move the main usages to a new CreateGames. Additional refactors around this is planned
How did you test this change?